Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify CHANNEL_FIELD16 as CHANNEL_NOTE_DURATION_MODIFIER #117

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

Rangi42
Copy link
Member

@Rangi42 Rangi42 commented Jun 13, 2024

These two fields aren't directly a 16-bit value, but they both deal with the note duration.

@Rangi42 Rangi42 requested review from mid-kid, dannye and vulcandth June 13, 2024 02:56
@Rangi42 Rangi42 marked this pull request as draft June 21, 2024 20:34
@Rangi42 Rangi42 force-pushed the field16 branch 2 times, most recently from 51811df to 01f5f82 Compare October 17, 2024 17:46
@Rangi42 Rangi42 changed the title Identify CHANNEL_FIELD16 as part of the note duration Identify CHANNEL_FIELD16 as CHANNEL_NOTE_DURATION_MODIFIER Dec 27, 2024
@Rangi42 Rangi42 marked this pull request as ready for review December 27, 2024 15:37
@Rangi42 Rangi42 merged commit 54b8389 into pret:master Dec 27, 2024
1 check passed
@Rangi42 Rangi42 deleted the field16 branch December 27, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant