Update comments and labels in src/engine/input_name.asm #152
Conversation
src/engine/input_name.asm
Outdated
| ; checks if any buttons were pressed and handles the input. | ||
| ; returns carry if either the A button or the B button were pressed. | ||
| ; this function is similar to 'CheckButtonState_DeckNamingScreen'. | ||
| CheckButtonState_PlayerNamingScreen: |
There was a problem hiding this comment.
This is not compliant to the Style Guide: https://github.com/pret/poketcg/blob/master/STYLE_GUIDE.md
Rather name it PlayerNamingScreen_CheckButtonState
src/engine/input_name.asm
Outdated
|
|
||
| Func_1aa07: | ||
| DrawInvisibleCursor_PlayerNamingScreen: |
There was a problem hiding this comment.
Rather name it PlayerNamingScreen_DrawInvisibleCursor
src/engine/input_name.asm
Outdated
| ; a = which tile to draw | ||
| ; [wNamingScreenCursorX] = cursor's x position on the keyboard screen | ||
| ; [wNamingScreenCursorY] = cursor's y position on the keyboard screen | ||
| DrawCursor_PlayerNamingScreen: |
There was a problem hiding this comment.
Rather name it PlayerNamingScreen_DrawCursor
There was a problem hiding this comment.
Also if this isn't used outside the scope of this routine, why use it as a global label?
src/engine/input_name.asm
Outdated
| call WriteByteToBGMap0 | ||
| or a | ||
| ret | ||
|
|
||
| Func_1aa23: | ||
| DrawVisibleCursor_PlayerNamingScreen: |
There was a problem hiding this comment.
Rather name it PlayerNamingScreen_DrawVisibleCursor
src/engine/input_name.asm
Outdated
| ; if "End" was selected. | ||
| NamingScreen_ProcessInput: | ||
| ; returns carry if "End" was selected on the keyboard | ||
| ProcessInput_PlayerNamingScreen: |
There was a problem hiding this comment.
Rather name it PlayerNamingScreen_ProcessInput
src/engine/input_name.asm
Outdated
| ; l = y position | ||
| ; output: | ||
| ; hl = KeyboardData_PlayerNamingScreen pointer | ||
| GetCharInfoFromPos_PlayerNamingScreen: |
There was a problem hiding this comment.
Rather name it PlayerNamingScreen_GetCharInfoFromPos
src/engine/input_name.asm
Outdated
| @@ -795,7 +851,7 @@ MACRO kbitem | |||
| ENDC | |||
| ENDM | |||
|
|
|||
| KeyboardData_Player: | |||
| KeyboardData_PlayerNamingScreen: | |||
There was a problem hiding this comment.
Rather name it PlayerNamingScreen_KeyboardData
src/engine/input_name.asm
Outdated
|
|
||
| Func_1afa1: | ||
| DrawInvisibleCursor_DeckNamingScreen: |
There was a problem hiding this comment.
Same styling comments apply here
src/engine/input_name.asm
Outdated
| ; a = which tile to draw | ||
| ; [wNamingScreenCursorX] = cursor's x position on the keyboard screen | ||
| ; [wNamingScreenCursorY] = cursor's y position on the keyboard screen | ||
| DrawCursor_DeckNamingScreen: |
There was a problem hiding this comment.
If this isn't used outside the scope of this routine, why use it as a global label?
I thought that it might be beneficial to incorporate some of the changes that I'm making in poketcg_v2 to the base disassembly, and this file seemed like a good place to start since it contained several unlabeled functions that were very similar to some other functions that were already labeled.