Switch back to whatwg-fetch #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jherdman
reviewed
Sep 30, 2018
| @@ -15,8 +15,7 @@ var FakeXMLHttpRequest = appearsBrowserified ? getModuleDefault(require('fake-xm | |||
| self.FakeXMLHttpRequest; | |||
|
|
|||
| // fetch related ponyfills | |||
| // TODO: use whatwg-fetch once new version release | |||
| var FakeFetch = appearsBrowserified ? getModuleDefault(require('@xg-wang/whatwg-fetch')) : self.WHATWGFetch; | |||
| var FakeFetch = appearsBrowserified ? getModuleDefault(require('whatwg-fetch')) : self.WHATWGFetch; | |||
There was a problem hiding this comment.
I noted in #221 thinking that it's a documentation bug, but self.WHATWGFetch is undefined for me.
|
@rwjblue @stefanpenner need review |
2 tasks
stefanpenner
approved these changes
Oct 4, 2018
|
@stefanpenner Do you think we should check the import of |
jherdman
added a commit
to jherdman/ember-cli-mirage
that referenced
this pull request
Oct 9, 2018
This change does not, like originally intended, make Pretender a peer dependency. There's a lot of work and debate being done here, so in the mean time let's unlock `fetch` support in Mirage. Dependency changes ------------------ * pretender 1.6 => 2.1. I've locked at 2.1.0 until pretenderjs/pretender#235 is resolved. This will require code changes on our end, and thus I don't want this sliding from underneath us and causing unnecessary weeping and gnashing of teeth. * Add xg-wang/whatwg-fetch. Required for the upgrade. * fake-xml-http-request 1.4.0 => 2.0.0. Required for the upgrade. * route-recognizer 0.2.3 => 0.3.4. Required for the upgrade. * ember-cli-node-assets 0.1.4 => 0.2.2. Because why not! I'm kneed deep in this stuff, so I may as well keep this up to date.
|
|
|
Anything need to do to get this merged? |
givanse
added a commit
to givanse/pretender
that referenced
this pull request
Jan 1, 2019
givanse
added a commit
to givanse/pretender
that referenced
this pull request
Jan 1, 2019
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JakeChampion/fetch@141665b...master
2 changes worth notice due to fetch spec change:
JakeChampion/fetch#651 JakeChampion/fetch#640