Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BankTransfer: Generate invoice after payment if invoice_generate=paid (Z#23144775) #30

Merged
merged 2 commits into from
Feb 16, 2024

Conversation

pc-coholic
Copy link
Member

@pc-coholic pc-coholic commented Feb 16, 2024

As of right now, the invoice-generation for Bank Transfer did not work as expected: the requires_invoice_immediately caused the invoice to be generated before the payment, thus generating an invoice without the Mollie payment information.

This change:

  • Defaults the requires_invoice_immediately property back to False (since we do not want the invoice before the payment)
  • Adds handling for invoice-generation after the payment if invoice_generate is set to paid if requires_invoice_immediately is True.

@pc-coholic pc-coholic changed the title SEPADebit: Generate invoice after payment if invoice_generate=paid (Z#23144775) BankTransfer: Generate invoice after payment if invoice_generate=paid (Z#23144775) Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant