Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function definition breaks priority: 1) parameters, 2) modifiers, 3) resultParameters #731

Merged
merged 2 commits into from
Sep 9, 2022

Conversation

Janther
Copy link
Contributor

@Janther Janther commented Sep 8, 2022

following the proposal of this #474 (comment)

Copy link
Member

@fvictorio fvictorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome 🎉 🎉 🎉

@Janther Janther force-pushed the function-definitions-formating branch from d318b09 to 9bf6d8f Compare September 9, 2022 19:35
@Janther Janther merged commit d7dea29 into main Sep 9, 2022
@Janther Janther deleted the function-definitions-formating branch September 9, 2022 19:39
@devinaconley
Copy link

awesome update @Janther @fvictorio! Has this made its way into a release yet?

@mattiaerre
Copy link
Member

mattiaerre commented Sep 26, 2022

hi, @devinaconley it looks like the latest release is this one: https://github.com/prettier-solidity/prettier-plugin-solidity/releases/tag/v1.0.0-dev.22 (07/10), and this PR has been merged after (09/09), so probably this has not been deployed yet // cc @fvictorio

Update: it looks like the latest published version in NPM is 1.0.0-dev.23, so we need to find out what's in that release

Update: the latest published version is 1.0.0-beta.24 actually https://www.npmjs.com/package/prettier-plugin-solidity/v/1.0.0-beta.24 and it was published a month ago by @fvictorio, so I think this PR has not been released yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants