Fix plugin search on pnpm

[fisker]

Local tested, it not easy to test, because this logic need plugin installed in same location with prettier.

Fixes #8056

• I’ve added tests to confirm my change works.
• (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
• (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/pr-XXXX.md file following changelog_unreleased/TEMPLATE.md.
• I’ve read the contributing guidelines.

✨Try the playground for this PR✨

[alexander-akait]

Can we add simple tests?

[fisker]

To setup this test, I need install pnpm, init a project, install prettier and one plugin, and run prettier from this project.

Seems not worth to do that.

[alexander-akait]

@fisker we can recreate the structure to make sure it works, in the future we can better automate testing, fixes without tests is bad idea

[fisker]

How do we put prettier self into node_modules/.pnpm/prettier@2.1.1/node_modules/prettier/?

[alexander-akait]

@fisker we can mock node_modules in tests and recreate structure in test/fixtures/node_modules/.pnpm

[aparajita]

Thanks for this @fisker!

[wighawag]

Would be great to have this merged, I switched to npm for my app template because of that.
is the tests the pending issue or is there something else ?

[aparajita]

@wighawag I'm using pnpm with prettier. There's an easy workaround, use the --plugin-search-dir or --plugin command line option.

[wighawag]

@aparajita I can make it work from the command line,
unfortunately it does not work on vscode plugin, but this fix proposed here might not fix the vscode plugin issue neither.
In vscode I also get the issue for eslint when used in conjunction with prettier

[alexander-akait]

/cc @fisker What do you think?

[thorn0]

FWIW, plugins and pluginSearchDirs can be specified in the config too. This might help with the VS Code use case.

[wighawag]

@thorn0 I tried that but without success, there seems to be other problem with the vscode plugin

[fisker]

@wighawag Are you running a global installed Prettier?

[wighawag]

No I use locally installed in the root of the mono repo.
My current workaround is to install prettier via npm in a _npm folder and use that path in the prettier vscode config
You can see it in this repo : https://github.com/wighawag/purple-warlock/tree/pnpm

[aparajita]

@wighawag You should file an issue with the eslint plugin maintainer.

[wighawag]

@aparajita you mean the prettier plugin I suppose

[aparajita]

@aparajita you mean the prettier plugin I suppose

Oops, yes.

[mdurling]

I don't believe this will work.node_modules/.pnpm is the default pnpm virtual store directory, but can be overridden by the virtual-store-dir setting in .npmrc.

[fisker]

Thanks for the information, any suggestion?

[mdurling]

Not sure. It seems the default path (or whatever is specified in pluginSearchDirs) is being resolved relative to process.cwd() which sits inside the pnpm virtual store. Packages in the virtual store aren't stored hierarchically so the concept of findParentDir does not really work. With pnpm, the package hierarchy is captured in the symlink structure, so the plugin searching will need to use the symlink (not the target) somehow. The only way I have gotten plugins to load is by specifying them in .prettierrc using a relative path, e.g. "plugins": ["./node_modules/prettier-plugin-packagejson"]

[mdurling]

I also use eslint plugins which seem to work fine with pnpm ... Looking at the eslint docs/internals it seems they resolve plugins as if you were to require them from the config file.

[aminya]

Could you accept this simple change as is and defer fine-tuned configuration? Prettier doesn't work with PNPM

[mdurling]

Prettier does work with pnpm, it just won’t auto load plugins. You can load them manually in the .prettierrc, for example: "plugins": ["./node_modules/prettier-plugin-packagejson"]

[adamhl8]

For anyone following this thread, I've created a PR that hopefully addresses this issue.

#11248

[syed-haroon]

I am switching from PNPM to NPM :(

[fz6m]

Rename .prettierrc to .prettierrc.js, use absolute plugin path to resolve this problem.

// .prettierrc.js

module.exports = {
  plugins: [
    require.resolve('prettier-plugin-packagejson'),
    // ...
  ]
}

[yavko]

Rename .prettierrc to .prettierrc.js, use absolute plugin path to resolve this problem.

// .prettierrc.js

module.exports = {
  plugins: [
    require.resolve('prettier-plugin-packagejson'),
    // ...
  ]
}

this doesn't work for me

[thonkinator]

any updates on this? it's been open for over 2 years now

[fz6m]

Currently the vscode prettier plugin supports resolve pnpm symlinks.

So you don't need require.resolve anymore.

// .prettierrc
{
  "plugins": ["some-plugin"]
}

[thonkinator]

@fz6m really? for me it doesn't detect pnpm packages either

[henrikvilhelmberglund]

This was broken for me and I had to migrate from pnpm to npm (loading plugins explicitly didn't work)