This repository has been archived by the owner on Nov 9, 2017. It is now read-only.
Fix routing with updated carbon-route #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -19,14 +19,14 @@ | |||
| "paper-elements": "polymerelements/paper-elements#^1.0.7", | |||
| "carbon-elements": "polymerelements/carbon-elements#^0.1.0", | |||
| "iron-elements": "polymerelements/iron-elements#^1.0.10", | |||
| "carbon-route": "TimvdLippe/carbon-route#subroute-updating", | |||
| "carbon-route": "TimvdLippe/carbon-route#reset-tail", | |||
There was a problem hiding this comment.
Why is carbonroute still in your fork, when it has been updated?
Or was it only partly merged?
There was a problem hiding this comment.
I updated my original PR (#subroute-updating) with some fixes. However, there was some discussion for 2 changes so I did not include these in the PR. Instead, I branched of into #reset-tail until further discussion has been resolved. For reference see PolymerElements/app-route#77 (comment)
|
Works fine. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
carbon-routehas been updated to correctly work with redirects. I changed the property checks toactiveto simplify the logic. Also fixed a bug with the collapse-arrow on the pull-request-list.