Descendents at depth. #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimpepper
requested changes
Feb 22, 2021
src/NestedSetInterface.php
Outdated
| */ | ||
| public function findDescendants(NodeKey $nodeKey, $depth = 0); | ||
| public function findDescendants(NodeKey $nodeKey, $depth = 0, $start = 0); |
There was a problem hiding this comment.
Oh it should be 1. Thanks!
kimpepper
reviewed
Feb 22, 2021
larowlan
reviewed
Feb 22, 2021
| @@ -616,6 +662,23 @@ public function testGetTree() { | |||
|
|
|||
| /** | |||
| * Loads the test data. | |||
| * | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without disturbing the existing $depth parameter, this provides an additional $start parameter. This is useful for those wanting to process a tree in layers (say building a visual representation), or if there is meaning to a specific layer, without doing a lot of php processing of the result set.
With the tree used in the tests, you can for example take 1 depth starting at depth 2.
Closes #23