Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

selected and dragged events #530

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

selected and dragged events #530

wants to merge 2 commits into from
+2 −2

Conversation

NouarSalhEddine
Copy link

No description provided.

@NouarSalhEddine NouarSalhEddine requested a review from prevwong as a code owner May 24, 2023 08:36
@netlify
Copy link

netlify bot commented May 24, 2023

✅ Deploy Preview for craftjs ready!

Name Link
🔨 Latest commit c2a9eaf
🔍 Latest deploy log https://app.netlify.com/sites/craftjs/deploys/646dcc98690d710008df4eb4
😎 Deploy Preview https://deploy-preview-530--craftjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@prevwong prevwong force-pushed the main branch 3 times, most recently from f14e620 to 84adfd1 Compare October 6, 2023 08:34
DenysVuika
DenysVuika reviewed Feb 11, 2024
View reviewed changes
site/docs/guides/basic-tutorial.md
@@ -635,8 +635,8 @@ The `useNode` hook accepts a collector function which can be used to retrieve st
// components/user/Text.js
export const Text = ({text, fontSize}) => {
const { connectors: {connect, drag}, hasSelectedNode, hasDraggedNode, actions: {setProp} } = useNode((state) => ({
hasSelectedNode: state.events.selected.size > 0,
hasDraggedNode: state.events.dragged.size > 0
selected: state.events.selected,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is is not going to work unless you rename the hasSelectedNode on the line above

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 27, 2025

⚠️ No Changeset found

Latest commit: 89e4b22

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Jan 27, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
craftjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 27, 2025 3:07pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DenysVuika DenysVuika DenysVuika left review comments

@prevwong prevwong Awaiting requested review from prevwong prevwong is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NouarSalhEddine @DenysVuika