Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better management of custom user_resources #36

Merged
merged 6 commits into from
May 5, 2019
Merged

Conversation

piotaixr
Copy link
Contributor

Fixes #35

Also this changes how admin_user_resource default is set. This avoids verbose config.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 111

  • 101 of 105 (96.19%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 93.545%

Changes Missing Coverage Covered Lines Changed/Added Lines %
spec/dummy/app/models/another_user.rb 5 9 55.56%
Totals Coverage Status
Change from base Build 109: 0.5%
Covered Lines: 913
Relevant Lines: 976

💛 - Coveralls

@michelson michelson merged commit 51d46b0 into prey:master May 5, 2019
@michelson
Copy link
Contributor

thanks @piotaixr ! sorry for the delay, it's merged on master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[readme?] Problem when user class has different name than User
3 participants