Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello guys, I'm currently playing with your GDPR engine. Thanks a lot for your work.
I've created a Rails sample app (https://github.com/EtienneDepaulis/rails_gdpr_sample_app) to try it more seriously before implementing on our production app.
I've noticed that you have pretty strict Rails requirements, every things seems to be working fine with 5.2.
In this PR I've also added common gitignore files and removed the Gemfile.lock (it looks like it is a best practice on other rails engines repo).
One question though : what about removing the mysql dependency for local work on the gem ?