[DEV-9918][DEV-10719] Switch to PNPM #382

aspirisen · 2023-01-29T14:04:23Z

Switch to pnpm
- Force resolution-mode=lowest-direct (see installing a dependency, by default, installs the lowest matching version of that dependency pnpm/pnpm#6463 (comment))
Bump Typescript language version to 4.9
Switch tests from jest to mocha
Extract storybook dependencies into own sub-package

aspirisen · 2023-01-30T00:53:12Z

packages/slate-editor/jest.config.cjs

            tsconfig: `${__dirname}/tsconfig.jest.json`,
        },
    },
    moduleNameMapper: {
+        '@prezly/slate-tables': path.join(__dirname, '../slate-tables/src'),


There is a problem with jsdom - it doesn't resolve modules like nodejs. Do not know why

e1himself

@aspirisen Do you have these warnings when you run pnpm build?

packages/slate-commons/src/plugins/withInlineVoid.ts

aspirisen · 2023-01-31T12:56:41Z

Do you have these warnings when you run pnpm build?

Yes, switched to old lock file format

e1himself · 2023-02-01T15:05:30Z

Works well now! Great! 👍

Also, let's squash all these commits upon merge (too many commits with crappy descriptions).

aspirisen · 2023-02-01T15:13:25Z

Also, let's squash all these commits upon merge (too many commits with crappy descriptions).

I will merge with squash

packages/slate-editor/src/extensions/placeholders/PlaceholdersExtension.tsx

aspirisen · 2023-03-29T11:23:49Z

@e1himself could you re-review this PR

aspirisen · 2023-03-31T12:36:06Z

@e1himself could take a look on this pr, I would like to merge it today (or I can just close this pr if these changes are not needed)

e1himself · 2023-04-04T07:49:05Z

@aspirisen My apologies for the delay. I'll review it today and merge. Thank you 🙏

packages/slate-editor/gulpfile.js

…`react-history` as workspace dependencies To share the dependencies across packages and also not have them in `packages/*/node_modules` (needed for package linking)

> could not unmarshal lockfile: : yaml

…kage node_modules And instead inherit them from the workspace root `node_modules`.

> Error: Undefined function.

…nguage features used

…ed in the workspace root

… root

…ypes

This reveals that the repo depends on `react-bootstrap` stylesheet, but we do not include them here :X

The approach we use is flawed anyway. See #382 (comment)

See: pnpm/pnpm#6463 (comment)

…y/lodash`

In order to fix ESM imports support

As there is no `@types/react-dom` past `16.9.9`, so no matching version for `react-dom@^16.14.0`

To keep `.d.ts` files next to their JS code versions. This will make the packages play well with TS 5.0. See microsoft/TypeScript#49160 (comment)

aspirisen self-assigned this Jan 29, 2023

aspirisen force-pushed the feature/DEV-9918-pnpm branch from 0283960 to b7271a8 Compare January 30, 2023 00:00

aspirisen changed the title ~~test~~ [DEV-9918] Switch to PNPM Jan 30, 2023

aspirisen commented Jan 30, 2023

View reviewed changes

aspirisen requested review from e1himself and kudlajz January 30, 2023 01:02

aspirisen marked this pull request as ready for review January 30, 2023 01:04

e1himself reviewed Jan 31, 2023

View reviewed changes

packages/slate-commons/src/plugins/withInlineVoid.ts Outdated Show resolved Hide resolved

aspirisen force-pushed the feature/DEV-9918-pnpm branch from 64f6bce to 9219a3b Compare February 2, 2023 13:05

aspirisen commented Feb 9, 2023

View reviewed changes

packages/slate-editor/src/extensions/placeholders/PlaceholdersExtension.tsx Outdated Show resolved Hide resolved

aspirisen changed the title ~~[DEV-9918] Switch to PNPM~~ [DEV-9918][QRF-927] Switch to PNPM Feb 9, 2023

aspirisen requested a review from e1himself February 10, 2023 12:47

aspirisen closed this Apr 3, 2023

e1himself reopened this Apr 4, 2023

aspirisen commented Apr 4, 2023

View reviewed changes

packages/slate-editor/gulpfile.js Outdated Show resolved Hide resolved

aspirisen and others added 9 commits May 2, 2023 17:56

[DEV-9918] Switch to pnpm

9ef5dfc

[DEV-9918] Fix root package clean targets

21ab6bf

[DEV-9918] Explicitly mark sub-packages as workspace-dependent

f468e6b

[DEV-9918] Declare react, react-dom, slate, slate-react, and …

c5dbeae

…`react-history` as workspace dependencies To share the dependencies across packages and also not have them in `packages/*/node_modules` (needed for package linking)

[DEV-9918] Drop lerna in favour of pnpm publish

e2bdb04

[DEV-9918] Fix release scripts

5be29a6

[DEV-9918] Update turbo.json to not complain on deprecated configuration

437142e

[DEV-9918] Upgrade turbo to fix complaints on lockfile unmarshaling

8764db8

> could not unmarshal lockfile: : yaml

[DEV-9918] Fix local React test matrix scripts

4a55eeb

e1himself added 26 commits May 3, 2023 13:51

[DEV-9918] Switch configs from package-lock.json to pnpm-lock.yaml

4ae25f9

[DEV-9918] Fix root package clean scripts (once more)

0923679

[DEV-9918] Skip installing sub-package peer dependencies into sub-pac…

01bee7e

…kage node_modules And instead inherit them from the workspace root `node_modules`.

[DEV-9918] Mark storybook sub-package not part of the root workspace

3171248

[DEV-9918] Ignore storybook output folder contents

c691175

[DEV-9918] Fix storybook shortcuts

2a99cec

[DEV-9918] Bump sass version to fix sass compilation error

6dd4a8c

> Error: Undefined function.

[DEV-9918] Bump typescript version to fix missing support of new la…

31f2d5f

…nguage features used

[DEV-9918] Make sure storybook is using the react package install…

a35dc23

…ed in the workspace root

[DEV-9918] Make sure we use the same @types/react as in the workspace…

8c91168

… root

[DEV-9918] Fix TS compilation error with outdated react-bootstrap t…

6e2b54a

…ypes

[DEV-9918] Add a Storybook entry for the floating menu

a3f6e95

This reveals that the repo depends on `react-bootstrap` stylesheet, but we do not include them here :X

[DEV-9918] Fix clean target

e62438a

[DEV-9918] Use react@16.9.0 with tests

1298063

[DEV-9918] Remove slate version tracking altogether

1d83cc4

The approach we use is flawed anyway. See #382 (comment)

[DEV-9918] Split "build" and "build storybook" workflows

70214d0

[DEV-9918] Fix prettier ignore for the new storybook code location

0738b37

[DEV-9918] Update prettier to work with new TS syntax

1eddcf7

[DEV-9918] Bump storybook packages to the latest version

40259ec

[DEV-9918] Enable resolution-mode=lowest-direct

6f1c7a3

See: pnpm/pnpm#6463 (comment)

[DEV-9918] Switch from ESM-only lodash-es to Universal `@technicall…

b79bd83

…y/lodash`

[DEV-9918] Switch from jest to mocha

74347ae

[DEV-9918] Fix storybook build

655a889

[DEV-9918] Bump minimal React version to 16.14.0

53cb2c7

In order to fix ESM imports support

[DEV-9918] Use @types/react-dom of 16.9.9 for react v16

a65a218

As there is no `@types/react-dom` past `16.9.9`, so no matching version for `react-dom@^16.14.0`

[DEV-9918] Flatten build folders

ab02fd3

To keep `.d.ts` files next to their JS code versions. This will make the packages play well with TS 5.0. See microsoft/TypeScript#49160 (comment)

e1himself approved these changes May 7, 2023

View reviewed changes

[DEV-9918] Bring back workspace: protocol version requirements

0d67f1e

e1himself merged commit 2e73249 into main May 7, 2023

e1himself deleted the feature/DEV-9918-pnpm branch May 7, 2023 21:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DEV-9918][DEV-10719] Switch to PNPM #382

[DEV-9918][DEV-10719] Switch to PNPM #382

aspirisen commented Jan 29, 2023 •

edited by e1himself

Loading

aspirisen Jan 30, 2023

e1himself left a comment

aspirisen commented Jan 31, 2023

e1himself commented Feb 1, 2023 •

edited

Loading

aspirisen commented Feb 1, 2023

aspirisen commented Mar 29, 2023

aspirisen commented Mar 31, 2023

e1himself commented Apr 4, 2023

[DEV-9918][DEV-10719] Switch to PNPM #382

[DEV-9918][DEV-10719] Switch to PNPM #382

Conversation

aspirisen commented Jan 29, 2023 • edited by e1himself Loading

aspirisen Jan 30, 2023

Choose a reason for hiding this comment

e1himself left a comment

Choose a reason for hiding this comment

aspirisen commented Jan 31, 2023

e1himself commented Feb 1, 2023 • edited Loading

aspirisen commented Feb 1, 2023

aspirisen commented Mar 29, 2023

aspirisen commented Mar 31, 2023

e1himself commented Apr 4, 2023

aspirisen commented Jan 29, 2023 •

edited by e1himself

Loading

e1himself commented Feb 1, 2023 •

edited

Loading