Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#659] 로그인 완료 후 이전 페이지로 돌아올 수 있는 기능 구현 #661

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

gxxrxn
Copy link
Member

@gxxrxn gxxrxn commented Jul 11, 2024

구현 내용

  • LoignLink 컴포넌트를 구현했어요.
    • 페이지 pathname을 search parameter에 담아 동적으로 로그인 url을 생성한 후, Link 태그의 href로 전달해요.
  • 추후 다른 OAuth 로그인도 대응하기 위해 LoginLink 라고 네이밍했어요.

관련 이슈

@gxxrxn gxxrxn added 🐥 프론트 필수! ✨ feature New feature or request 🔥 v.1.0 New feature for releasing v.1.0 labels Jul 11, 2024
@gxxrxn gxxrxn requested a review from hanyugeon July 11, 2024 18:42
@gxxrxn gxxrxn self-assigned this Jul 11, 2024
Copy link

vercel bot commented Jul 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dadok ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2024 6:42pm

Copy link

Copy link

⚡️ Lighthouse Average Scores Across Reports:

Category Score
🔴 performance 69
🟢 accessibility 91
🟢 best practices 98
🟢 seo 100
🟢 pwa 100

⚡️ Average Details Across All Reports:

Category Score
🟢 first contentful paint 0.8s
🔴 largest contentful paint 12.8s
🔴 interactive 7.8s
🟢 total blocking time 252.5ms
🟢 cumulative layout shift 0.0

Copy link
Member

@hanyugeon hanyugeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

로그인시 너무 이동이 잘 되고있어요!! 고생하셨습니다 💯

@gxxrxn gxxrxn merged commit f34d416 into main Jul 11, 2024
4 checks passed
@gxxrxn gxxrxn deleted the feat/#659 branch July 11, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ feature New feature or request 🐥 프론트 필수! 🔥 v.1.0 New feature for releasing v.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

로그인 완료 후 이전 페이지로 돌아올 수 있는 기능 구현
2 participants