This repository has been archived by the owner on May 19, 2024. It is now read-only.
[BM-246] 로그인 요청 url의 리다이렉트 url로 로그인시 리다이렉트 #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UJ15
requested review from
waterfogSW,
gkdud583,
dojinyou and
youngjunryu
as code owners
Codecov Report
@@ Coverage Diff @@
## main #111 +/- ##
============================================
- Coverage 81.62% 79.53% -2.09%
Complexity 364 364
============================================
Files 74 75 +1
Lines 1132 1163 +31
Branches 27 32 +5
============================================
+ Hits 924 925 +1
- Misses 190 220 +30
Partials 18 18
Continue to review full report at Codecov.
|
|
📊 BidMarket-pr-111 분석 결과 확인 링크 |
waterfogSW
approved these changes
Aug 7, 2022
Comment on lines
19
to
23
| for (Cookie cookie : cookies) { | ||
| if (cookie.getName().equals(name)) { | ||
| return Optional.of(cookie); | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| for (Cookie cookie : cookies) { | |
| if (cookie.getName().equals(name)) { | |
| return Optional.of(cookie); | |
| } | |
| } | |
| return Arrays.stream(cookies) | |
| .filter(cookie -> cookie.getName().equals(name)) | |
| .findFirst(); |
스트림쓰면 더 가독성있게 쓸 수 있을것 같습니다
|
📊 BidMarket-pr-111 분석 결과 확인 링크 |
|
📊 BidMarket-pr-111 분석 결과 확인 링크 |
|
📊 BidMarket-pr-111 분석 결과 확인 링크 |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
기존에 하드코딩으로 되어있던 리다이렉트 url을 프론트에서 처음 요청시 redirect url로 리다이렉트 하도록 수정했습니다.
localhost:8080/oauth2/authorization/google?redirect_uri=http://localhost:3000/auth
이렇게 로그인 요청시 localhost:3000/auth로 리다이렉트 해줌