Skip to content
This repository has been archived by the owner on May 19, 2024. It is now read-only.

[BM-142] 회원 정보 수정 Service 메서드 구현 #37

Merged
merged 3 commits into from
Jul 31, 2022
Merged

[BM-142] 회원 정보 수정 Service 메서드 구현 #37

merged 3 commits into from
Jul 31, 2022

Conversation

UJ15
Copy link
Member

@UJ15 UJ15 commented Jul 31, 2022

Service 레이어의 회원 정보 수정 기능 테스트와 프로덕션 코드를 구현했습니다.

  • User Entity에 update 메서드를 추가했습니다.
  • UserService에 update 메서드를 추가했습니다.
  • 해당 메서드 테스트 코드를 작성했습니다.

entity의 update 메서드에서 인자 검증 의미가 있는 검증일까요?

@codecov-commenter
Copy link

Codecov Report

Merging #37 (adb0989) into main (d94f5b0) will increase coverage by 0.58%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #37      +/-   ##
============================================
+ Coverage     70.51%   71.10%   +0.58%     
- Complexity      132      134       +2     
============================================
  Files            33       33              
  Lines           563      571       +8     
  Branches         15       15              
============================================
+ Hits            397      406       +9     
+ Misses          160      159       -1     
  Partials          6        6              
Impacted Files Coverage Δ
...ain/java/com/saiko/bidmarket/user/entity/User.java 86.36% <100.00%> (+4.01%) ⬆️
...iko/bidmarket/user/service/DefaultUserService.java 100.00% <100.00%> (+3.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d94f5b0...adb0989. Read the comment docs.

@github-actions
Copy link

📊 BidMarket-pr-37 분석 결과 확인 링크

Copy link
Member

@dojinyou dojinyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

필요하다면 어떤 함수든 인자에 대한 검증을 해주는 게 가장 좋다고 생각합니다!
그래서 이러한 검증이 반복되지 않도록 객체 필드에 대응되는 클래스를 만들고 그 클래스를 활용하여 검증을 한다고 생각합니다!!

Comment on lines +66 to +67
Assert.notNull(profileImage, "profileImage must be provide");

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

사용자의 profile image가 없는 경우는 없나요??
실제로 없는 경우에는 어떻게 처리하면 좋을까요?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

구글 OAuth 로그인시 구글 프로필 사진을 유저 정보에 저장합니다. 프론트에서 요청을 보낼때 기존 데이터를 보내주면 될것 같습니다.

@UJ15 UJ15 merged commit 008ef1b into main Jul 31, 2022
@UJ15 UJ15 deleted the BM-142 branch July 31, 2022 08:26
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants