-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: storybook 바벨 이슈 수정 #139
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chojooyoung
reviewed
Oct 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
컨벤센 관련해서 정하고 approve 누르겠습니다!
이슈공유 감사합니다!
sonsurim
previously approved these changes
Oct 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
sonsurim
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 이슈 번호
⛳ 구현 사항
📚 구현 설명
@types/react
,@types/react-dom
의 버전을 고정을 위해 package.json에 resolutions를 추가하였습니다. (관련 자료)💡 코드 리뷰 포인트
🔥 이슈와 해결 방안
babel 이슈 발생
시도 방법
storybook/babel.config.js
파일을 main에 extends하여 해당 파일을 바라보게 해주려 시도했지만 계속 root 파일을 바라봄해결 방법
이슈를 서치해보니 storybook v7에서는 next에 관련된 설정을 세팅해주는 plugin을 제공한다고 하여(관련 자료](storybookjs/storybook#23063)), v7로 마이그레이션해 문제를 해결 (마이그레이션 자료)
추가적인 이슈
@types/react
,@types/react-dom
의 버전을 고정을 위해 package.json에 resolutions를 추가하여 해결 (관련 자료)