Pull in latest release 13.0.1 (#3292)

* Fix translation path (#3198) * Change product variant swatches' border color (#3204) * change color reference * remove character * increase to meet contrast ratio of 3 * Update swatch setting info text (#3205) * Update info text * remove duplication * add space * clean up language and association * add to second place * Update 9 translation files * Update 4 translation files * Update 6 translation files * Update 1 translation file --------- Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> * [Quick order list] Change 'plural' string to 'singular' when removing '1 item' on 'Remove all' confirmation (#3203) * Change the message when removing only one item from the QOL * Update 20 translation files * Update 6 translation files * Update 4 translation files --------- Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> * Fix drawer stylings (#3248) * Update 1 translation file (#3202) Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> * Pull update from release branch and update version number and release notes (#3229) * Fix translation path (#3198) * Change product variant swatches' border color (#3204) * change color reference * remove character * increase to meet contrast ratio of 3 * Update swatch setting info text (#3205) * Update info text * remove duplication * add space * clean up language and association * add to second place * Update 9 translation files * Update 4 translation files * Update 6 translation files * Update 1 translation file --------- Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> * [Quick order list] Change 'plural' string to 'singular' when removing '1 item' on 'Remove all' confirmation (#3203) * Change the message when removing only one item from the QOL * Update 20 translation files * Update 6 translation files * Update 4 translation files --------- Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> * Update 1 translation file (#3202) Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> * update version number and release notes --------- Co-authored-by: melissaperreault <melissa.perreault@shopify.com> Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> Co-authored-by: Eugene Kasimov <105315663+eugenekasimov@users.noreply.github.com> * Update 1 translation file (#3232) Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> * Fix cart drawer header background and cart note summary spacing * more cart drawer touch ups * remove some of the unwanted changes --------- Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> Co-authored-by: melissaperreault <melissa.perreault@shopify.com> Co-authored-by: Eugene Kasimov <105315663+eugenekasimov@users.noreply.github.com> * fix missing alt tags for collection images (#3262) * Update titles (#3265) * Condense country selector width when there are no currencies (#3269) * Recreate existing PR based on the right branch (#3274) * Fix product review alignment when product doesn't have medias (#3264) * Fix product review alignment when product doesn't have medias * Add the escape to match with branch target * Touch up scroll into view PDP (#3276) * Fix mobile behaviour for scroll into view * remove conditions * remove unused data attribute (#3277) * Remove sticky header on cart drawer to avoid overlap of content (#3279) * fix scrolling scenario on mobile (#3286) * Update 1 translation file (#3202) Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> * Pull update from release branch and update version number and release notes (#3229) * Fix translation path (#3198) * Change product variant swatches' border color (#3204) * change color reference * remove character * increase to meet contrast ratio of 3 * Update swatch setting info text (#3205) * Update info text * remove duplication * add space * clean up language and association * add to second place * Update 9 translation files * Update 4 translation files * Update 6 translation files * Update 1 translation file --------- Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> * [Quick order list] Change 'plural' string to 'singular' when removing '1 item' on 'Remove all' confirmation (#3203) * Change the message when removing only one item from the QOL * Update 20 translation files * Update 6 translation files * Update 4 translation files --------- Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> * Update 1 translation file (#3202) Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> * update version number and release notes --------- Co-authored-by: melissaperreault <melissa.perreault@shopify.com> Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> Co-authored-by: Eugene Kasimov <105315663+eugenekasimov@users.noreply.github.com> * Update 1 translation file (#3232) Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> * Update README.md (#3128) * Update README.md * fix url formatting --------- Co-authored-by: Ludo <ludo.segura@shopify.com> * Fix Theme Check offences (#3283) * Fix schema JSON formatting Co-authored-by: Abhishek Jani <abhishekdarshanjani@gmail.com> * Add loading=eager attribute to gift card page img * Use liquid tag to combine successive liquid statements Co-authored-by: Abhishek Jani <abhishekdarshanjani@gmail.com> * Remove snippet to avoid > 3 levels of nested snippets * Ignore AssetPreload theme check for font links --------- Co-authored-by: Abhishek Jani <abhishekdarshanjani@gmail.com> * update release notes --------- Co-authored-by: melissaperreault <melissa.perreault@shopify.com> Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> Co-authored-by: Eugene Kasimov <105315663+eugenekasimov@users.noreply.github.com> Co-authored-by: Renan Souza <77407058+renanvsouza@users.noreply.github.com> Co-authored-by: Abdulrahman Hamideh <abdulrahman.hamideh@shopify.com> Co-authored-by: Benjamin Sehl <ben@sehl.ca> Co-authored-by: Kai <KaichenWang@users.noreply.github.com> Co-authored-by: Abhishek Jani <abhishekdarshanjani@gmail.com>
pridyok · Feb 23, 2024 · c5ba94b · c5ba94b
1 parent a42f234
commit c5ba94b
Show file tree

Hide file tree

Showing 13 changed files with 735 additions and 623 deletions.
diff --git a/assets/component-cart-drawer.css b/assets/component-cart-drawer.css
@@ -100,8 +100,8 @@ cart-drawer:not(.is-empty) .cart-drawer__collection {
 }
 
 .drawer__close svg {
-  height: 2.4rem;
-  width: 2.4rem;
+  height: 2rem;
+  width: 2rem;
 }
 
 .drawer__contents {
@@ -132,7 +132,7 @@ cart-drawer-items.is-empty + .drawer__footer {
   display: flex;
   position: relative;
   line-height: 1;
-  padding: 1.5rem 0;
+  padding: 1.5rem 2.8rem 1.5rem 0;
 }
 
 .drawer__footer > details + .cart-drawer__footer {
@@ -182,9 +182,6 @@ cart-drawer {
 .cart-drawer thead {
   display: inline-table;
   width: 100%;
-  position: sticky;
-  top: 0;
-  z-index: 2;
 }
 
 cart-drawer-items {
@@ -205,7 +202,7 @@ cart-drawer-items {
 .cart-drawer .cart-item {
   display: grid;
   grid-template: repeat(2, auto) / repeat(4, 1fr);
-  gap: 1.5rem;
+  gap: 1rem;
   margin-bottom: 0;
 }
 
@@ -255,7 +252,7 @@ cart-drawer-items {
 }
 
 .cart-drawer .cart-items td {
-  padding-top: 2rem;
+  padding-top: 1.7rem;
 }
 
 .cart-drawer .cart-item > td + td {
@@ -312,7 +309,7 @@ cart-drawer-items {
 }
 
 .cart-drawer .tax-note {
-  margin: 1.2rem 0 1rem auto;
+  margin: 1.2rem 0 2rem auto;
   text-align: left;
 }
 

diff --git a/assets/component-localization-form.css b/assets/component-localization-form.css
@@ -173,11 +173,14 @@ noscript .localization-selector.link {
 }
 
 .country-selector__list {
-  width: 25.5rem;
   padding-bottom: 0.95rem;
   padding-top: 0;
 }
 
+.country-selector__list--with-multiple-currencies {
+  width: 25.5rem;
+}
+
 .country-selector__close-button {
   display: none;
 }

diff --git a/assets/component-rating.css b/assets/component-rating.css
@@ -1,3 +1,7 @@
+.product--no-media .rating-wrapper {
+  text-align: center;
+}
+
 .rating {
   display: inline-block;
   margin: 0;

diff --git a/assets/media-gallery.js b/assets/media-gallery.js
@@ -46,12 +46,14 @@ if (!customElements.get('media-gallery')) {
 
         this.preventStickyHeader();
         window.setTimeout(() => {
-          if (this.elements.thumbnails) {
+          if (!this.mql.matches || this.elements.thumbnails) {
             activeMedia.parentElement.scrollTo({ left: activeMedia.offsetLeft });
           }
-          if (!this.elements.thumbnails || this.dataset.desktopLayout === 'stacked') {
-            activeMedia.scrollIntoView({ behavior: 'smooth' });
-          }
+          const activeMediaRect = activeMedia.getBoundingClientRect();
+          // Don't scroll if the image is already in view
+          if (activeMediaRect.top > -0.5) return;
+          const top = activeMediaRect.top + window.scrollY;
+          window.scrollTo({ top: top, behavior: 'smooth' });
         });
         this.playActiveMedia(activeMedia);
 

diff --git a/release-notes.md b/release-notes.md
@@ -1,15 +1,10 @@
-Dawn 13.0.0 adds support for color swatches, improvements to the country selector, and tweaks and fixes to other sections. It also includes a breaking change to Color Schemes; see the Changed notes below for details.
-### Added
-- The Variant Picker now supports color swatches! This depends on the [Product Taxonomy](help.shopify.com/manual/products/details/product-category) feature, which is rolling out gradually over the coming weeks.
-- We reworked the country selector, which now includes search, a new “popular countries” section, and a generally improved look and feel especially on smaller screens.
+Dawn 13.0.1 introduces a few fixes.
 ### Changed
-- **Important**: If you use Color Schemes, they will reset to their default values due to an internal change to the feature.
-- If you are using the Search & Discovery app, you can now change how dynamic facet lists treat filters with no product matches.
+- The cart drawer header (Product, Total) is not sticky anymore when the content is scrollable
 ### Fixes and improvements
-- We added a default font for input fields, they now inherit the body font instead of falling back to a system default font.
-- We fixed an issue when adding cart notes that would prevent them from showing during checkout.
-- We fixed an accessibility bug where filter colors were displaying incorrectly in high contrast mode.
-- We updated the Multicolumn Section to provide a slider on tablet-sized screens, like it does on phone-sized screens.
-- We fixed a bug where the Localization Selector was slightly obscured when using Sticky Header and scrolling while the selector was open.
-- We fixed a bug that prevented the Product Grid Section from using the correct Image Shape in its Product Cards.
-- We subtly increased the font size for inline quantity errors on product pages to make them more readable.
+- Fix product rating alignment when the product doesn't have a media
+- Fix scroll issue on variant change
+- Limit width of country selector when the currency is the same for all the countries
+- Fix missing alt tags for the collection image on the collection page as well as for collection cards
+- Fix cart drawer's cart note to prevent overlapping of the text and caret icon
+- Fix cart drawer's header to prevent an overlap with the items in the cart
diff --git a/sections/collapsible-content.liquid b/sections/collapsible-content.liquid
@@ -83,7 +83,7 @@
                   <summary id="Summary-{{ block.id }}-{{ section.id }}">
                     {% render 'icon-accordion', icon: block.settings.icon %}
                     <h3 class="accordion__title inline-richtext h4">
-                      {{ block.settings.heading | default: block.settings.page.title }}
+                      {{ block.settings.heading | default: block.settings.page.title | escape }}
                     </h3>
                     {% render 'icon-caret' %}
                   </summary>

diff --git a/sections/featured-collection.liquid b/sections/featured-collection.liquid
@@ -158,7 +158,7 @@
         <a
           href="{{ section.settings.collection.url }}"
           class="{% if section.settings.view_all_style == 'link' %}link underlined-link{% elsif section.settings.view_all_style == 'solid' %}button{% else %}button button--secondary{% endif %}"
-          aria-label="{{ 'sections.featured_collection.view_all_label' | t: collection_name: section.settings.collection.title }}"
+          aria-label="{{ 'sections.featured_collection.view_all_label' | t: collection_name: section.settings.collection.title | escape }}"
         >
           {{ 'sections.featured_collection.view_all' | t }}
         </a>

diff --git a/sections/featured-product.liquid b/sections/featured-product.liquid
@@ -468,39 +468,41 @@
                 {{ block.settings.custom_liquid }}
               {%- when 'rating' -%}
                 {%- if product.metafields.reviews.rating.value != blank -%}
-                  {% liquid
-                    assign rating_decimal = 0
-                    assign decimal = product.metafields.reviews.rating.value.rating | modulo: 1
-                    if decimal >= 0.3 and decimal <= 0.7
-                      assign rating_decimal = 0.5
-                    elsif decimal > 0.7
-                      assign rating_decimal = 1
-                    endif
-                  %}
-                  <div
-                    class="rating"
-                    role="img"
-                    aria-label="{{ 'accessibility.star_reviews_info' | t: rating_value: product.metafields.reviews.rating.value, rating_max: product.metafields.reviews.rating.value.scale_max }}"
-                  >
-                    <span
-                      aria-hidden="true"
-                      class="rating-star"
-                      style="--rating: {{ product.metafields.reviews.rating.value.rating | floor }}; --rating-max: {{ product.metafields.reviews.rating.value.scale_max }}; --rating-decimal: {{ rating_decimal }};"
-                    ></span>
+                  <div class="rating-wrapper">
+                    {% liquid
+                      assign rating_decimal = 0
+                      assign decimal = product.metafields.reviews.rating.value.rating | modulo: 1
+                      if decimal >= 0.3 and decimal <= 0.7
+                        assign rating_decimal = 0.5
+                      elsif decimal > 0.7
+                        assign rating_decimal = 1
+                      endif
+                    %}
+                    <div
+                      class="rating"
+                      role="img"
+                      aria-label="{{ 'accessibility.star_reviews_info' | t: rating_value: product.metafields.reviews.rating.value, rating_max: product.metafields.reviews.rating.value.scale_max }}"
+                    >
+                      <span
+                        aria-hidden="true"
+                        class="rating-star"
+                        style="--rating: {{ product.metafields.reviews.rating.value.rating | floor }}; --rating-max: {{ product.metafields.reviews.rating.value.scale_max }}; --rating-decimal: {{ rating_decimal }};"
+                      ></span>
+                    </div>
+                    <p class="rating-text caption">
+                      <span aria-hidden="true">
+                        {{- product.metafields.reviews.rating.value }} /
+                        {{ product.metafields.reviews.rating.value.scale_max -}}
+                      </span>
+                    </p>
+                    <p class="rating-count caption">
+                      <span aria-hidden="true">({{ product.metafields.reviews.rating_count }})</span>
+                      <span class="visually-hidden">
+                        {{- product.metafields.reviews.rating_count }}
+                        {{ 'accessibility.total_reviews' | t -}}
+                      </span>
+                    </p>
                   </div>
-                  <p class="rating-text caption">
-                    <span aria-hidden="true">
-                      {{- product.metafields.reviews.rating.value }} /
-                      {{ product.metafields.reviews.rating.value.scale_max -}}
-                    </span>
-                  </p>
-                  <p class="rating-count caption">
-                    <span aria-hidden="true">({{ product.metafields.reviews.rating_count }})</span>
-                    <span class="visually-hidden">
-                      {{- product.metafields.reviews.rating_count }}
-                      {{ 'accessibility.total_reviews' | t -}}
-                    </span>
-                  </p>
                 {%- endif -%}
               {%- when 'icon-with-text' -%}
                 {% render 'icon-with-text', block: block %}

diff --git a/sections/main-collection-banner.liquid b/sections/main-collection-banner.liquid
@@ -36,7 +36,7 @@
           "
           src="{{ collection.image | image_url: width: 750 }}"
           sizes="(min-width: {{ settings.page_width }}px) {{ settings.page_width | minus: 100 | divided_by: 2 }}px, (min-width: 750px) calc(50vw - 130px), calc(50vw - 55px)"
-          alt=""
+          alt="{{ collection.image.alt | escape }}"
           width="{{ collection.image.width }}"
           height="{{ collection.image.height }}"
         >