-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CMSSE-730]: Fix docs and warning for redis cache config #204
[CMSSE-730]: Fix docs and warning for redis cache config #204
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable to me. Being that prima_auth0_ex, :redis, :enabled
is deprecated there's no reason to let it live in the readme.
But maybe might be worth it to add another match after {true, nil}
like:
{true, provider} ->
Application.put_env(:prima_auth0_ex, :token_cache, provider)
?
Moreover, being that here you are, can you please fix the typo? It's written provieder
XD.
If you think it's out of scope no worries, i'll open a card on our board with those changes
@cottinisimone I don't get it, the provider is read from config so why would I put it back in the config? |
I'm just saying that some user might have an older version of |
Co-authored-by: Simone Cottini <cottini.simone@gmail.com>
The config as I copied it from the readme didn't work - and there wasn't a warning for it just a failed pattern match.
I've created this mood board to explain the problem:
Could well be the case that I've misread something but gave it a go to fix it. Possibly pattern matching on
:'Elixir.EncryptedRedisTokenCache'
isn't very nice because I guess fully qualified or aliased module names wouldn't match - I can't think of a nicer solution though.