[PLATFORM-480]: [Auth0Ex] Understand how to enforce https on Redix #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpiemontese
requested review from
dinopascale-prima,
enricoantonioliprima and
mbusi
mbusi
reviewed
May 31, 2022
dinopascale-prima
requested changes
Jun 1, 2022
cpiemontese
deleted the
PLATFORM-480/user-story/auth-ex-understand-how-to-enforce-https-on-redix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://prima-assicurazioni-spa.myjetbrains.com/youtrack/issue/PLATFORM-480
This PR tries to address the problem described here i.e. the need for an additional socket option to allow wildcard certificates and thus have successful verification when using ssl with Amazon Elasticache (which we need to be able to authenticate with our Redis).
We added two new config options:
:redis_ssl_enabled,:redis_ssl_allow_wildcard_certificateswhich default to
falseand can be used to enable ssl and, optionally, add the additional socket configuration.Theoretically the
ssloption could be specified in the redis uri (e.g. using "?ssl=true") but this doesn't seem to be standard and this way it seems more robust.