Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump jfmengels/elm-review from 2.10.0 to 2.13.0 in /review #17

Closed

Conversation

dependabot[bot]
Copy link

@dependabot dependabot bot commented on behalf of github May 1, 2023

Bumps jfmengels/elm-review from 2.10.0 to 2.13.0.

Changelog

Sourced from jfmengels/elm-review's changelog.

[2.13.0] - 2023-04-16

  1. Changed the order in which rules are applied on modules. #153

Instead of visiting the entire project for each rule sequentially, we now visit the entire project once but apply each rule on each module. This should hopefully result in a small speed improvement, and make it more interesting to precompute interesting information to provide the rules (such as the module name lookup table)

  1. Made it less costly to compute whether cached analysis can be reused #154

The caching mechanism introduced in [2.11.0] felt inefficient. It improved the performance a bit but not as significantly as expected. The reason for that was that the method to check whether a cached analysis could be re-used or not was extremely inefficient. Changing the representation of that key vastly improved the performance of the whole cache system, which now feels worth it.

  1. Applying fixes for all targets #155

In [2.10.0] the package introduced the ability to apply fixes on its own, without the need of the CLI. It did however not support applying fixes for the elm.json file, as that can have important repercussions on the analysis (if source-directories or dependencies are changed). These fixes are now applied as well.

Applying all fixes in the package means that there is no need to try and apply fixes in the CLI, which will be removed in its v2.10.0. The CLI was responsible for annotating fixes as failing, which is why this release introduces [Review.Rule.errorFixFailure] to allow the CLI to show when a fix failed to apply.

[2.12.2] - 2023-02-02

Fixed a bug where errors were skipped/ignored when running elm-review after having run elm-review --fix-all #150

[2.12.1] - 2023-01-25

Fixed a bug where rules would report false positives in the presence of the file-system cache.

[2.12.0] - 2023-01-22

Fixed a bug that ignored fixes from rules that were not marked as providing fixes (using Rule.providesFixesFor*Rule). This was meant to be handled by the CLI, but didn't work as expected.

When the rule uses [Review.Rule.withIsFileIgnored], the test runner will now attempt to re-run the rule while ignoring some files (it will do so for every possible combination) and assert that the results are the same. This is to check that the knowledge is only used for performance improvements and change the result. This way, complex rules can avoid writing extremely complicated test setups to test that complex scenarios work behave as expected even when some files are ignored.

Some rules might not wish for this behavior, in which case [Review.Test.ignoredFilesImpactResults] can be used to opt out of this re-running mechanism.

[2.11.1] - 2022-12-20

... (truncated)

Commits
  • 171a54d 2.13.0
  • f5cf817 Remove outdated TODOs
  • c3fee90 Add TODOs
  • 378fd4c Remove redundant argument to Compute.registerVariable
  • f9da2e3 Add TODOs for v3
  • 154aeef Use the same cache for data extract and for FinalProjectEvaluation
  • 865b3e1 Move cache for final project evaluation into separate module
  • 02e73bf Move cache for project files into separate module
  • 02f3a30 Move cache for modules into separate module
  • e075e43 Rename cache for final evaluation
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [jfmengels/elm-review](https://github.com/jfmengels/elm-review) from 2.10.0 to 2.13.0.
- [Release notes](https://github.com/jfmengels/elm-review/releases)
- [Changelog](https://github.com/jfmengels/elm-review/blob/master/CHANGELOG.md)
- [Commits](jfmengels/elm-review@2.10.0...2.13.0)

---
updated-dependencies:
- dependency-name: jfmengels/elm-review
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file elm Pull requests that update Elm code labels May 1, 2023
@dependabot @github
Copy link
Author

dependabot bot commented on behalf of github Jul 1, 2023

Superseded by #20.

@dependabot dependabot bot closed this Jul 1, 2023
@dependabot dependabot bot deleted the dependabot/elm/review/jfmengels/elm-review-2.13.0 branch July 1, 2023 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file elm Pull requests that update Elm code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants