[PLATFORM-861]: Fix borked enum variant name formatting #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaeIsBad
reviewed
Dec 15, 2022
src/private.rs
Outdated
| /// Whether the type we're redacting is an Option<T> or not. Poor man's specialization! This is detected | ||
| /// by the proc macro reading the path to the type, so it's not perfect. | ||
| /// | ||
| /// This could be improved & rid of in a number of different ways in the future: | ||
| /// | ||
| /// * Once specialization is stabilized, we can use a trait to override redacting behaviour for some types, | ||
| /// * Once specialization is stabilized, we can use a trait to override redacting behavior for some types, |
There was a problem hiding this comment.
I can't believe a british dev would do this. Did it hurt?
|
Moved my review over to #60 where it belongs |
WilliamVenner
force-pushed
the
PLATFORM-861/user-story/fix-borked-enum-variant-name-formatting
branch
from
15af92f to
caba792
Compare
cpiemontese
approved these changes
Dec 19, 2022
| @@ -168,7 +168,7 @@ pub(super) fn derive_redact( | |||
| for (variant, flags) in e.variants.iter().zip(variant_flags.into_iter()) { | |||
| // Variant name redacting | |||
| let variant_name = variant.ident.to_string(); | |||
| let variant_name = if let Some(flags) = &flags.variant_flags { | |||
| let variant_name = if let Some(flags @ FieldFlags { skip: false, .. }) = &flags.variant_flags { | |||
There was a problem hiding this comment.
This is for me: wth is @?
There was a problem hiding this comment.
it binds the flags variable and matches the pattern
https://doc.rust-lang.org/stable/rust-by-example/flow_control/match/binding.html
There was a problem hiding this comment.
such an awesome feature :)
WilliamVenner
deleted the
PLATFORM-861/user-story/fix-borked-enum-variant-name-formatting
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://prima-assicurazioni-spa.myjetbrains.com/youtrack/issue/PLATFORM-861
Fixes a weird edge case where enum variant names were not being formatted correctly.
Added tests to ensure that we don't regress this in future.