Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLATFORM-997]: Spike: Migrate a veil repo to use GitHub Actions #71

Merged
merged 11 commits into from
May 4, 2023
Merged

[PLATFORM-997]: Spike: Migrate a veil repo to use GitHub Actions #71

merged 11 commits into from
May 4, 2023

Conversation

MaeIsBad
Copy link
Member

@MaeIsBad MaeIsBad commented Apr 4, 2023

@MaeIsBad MaeIsBad requested a review from a team as a code owner April 4, 2023 10:19
MaeIsBad and others added 2 commits April 4, 2023 12:35
@MaeIsBad MaeIsBad requested a review from cottinisimone April 5, 2023 08:48
cottinisimone
cottinisimone previously approved these changes Apr 5, 2023
View reviewed changes
@MaeIsBad MaeIsBad requested a review from cpiemontese April 5, 2023 11:44
cpiemontese
cpiemontese previously approved these changes Apr 5, 2023
View reviewed changes
Copy link
Contributor

@cpiemontese cpiemontese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems ok, even though I'd be curious to test out a release

That said it seems we still need to remove the drone check

@MaeIsBad
Copy link
Member Author

MaeIsBad commented Apr 5, 2023

This seems ok, even though I'd be curious to test out a release

as far as I can tell it seems to work(tested on a different branch with dry-run)

@MaeIsBad MaeIsBad dismissed stale reviews from cpiemontese and cottinisimone via e2bda82 April 11, 2023 16:38
@MaeIsBad MaeIsBad force-pushed the PLATFORM-997/task/migrate-to-github-actions branch from fc635db to 0b64d5a Compare April 11, 2023 16:47
@MaeIsBad MaeIsBad requested a review from cpiemontese May 2, 2023 15:43
@MaeIsBad MaeIsBad force-pushed the PLATFORM-997/task/migrate-to-github-actions branch 7 times, most recently from 8ffa252 to a29a0a1 Compare May 2, 2023 16:33
@MaeIsBad MaeIsBad force-pushed the PLATFORM-997/task/migrate-to-github-actions branch from a29a0a1 to bed74cc Compare May 2, 2023 16:33
@MaeIsBad
Copy link
Member Author

MaeIsBad commented May 2, 2023

I've made a small mistake in our umami PR, which causes our PRs to require the ugly "CI / Continuous Integration / test" check names. I propose we merge this as is and I'll fix this in a separate umami PR

@MaeIsBad MaeIsBad requested a review from oliverbrowneprima May 2, 2023 16:35
@MaeIsBad MaeIsBad merged commit dfb7331 into master May 4, 2023
@MaeIsBad MaeIsBad deleted the PLATFORM-997/task/migrate-to-github-actions branch May 4, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpiemontese cpiemontese cpiemontese approved these changes

@cottinisimone cottinisimone cottinisimone left review comments

@oliverbrowneprima oliverbrowneprima Awaiting requested review from oliverbrowneprima

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MaeIsBad @cpiemontese @cottinisimone @oliverbrowneprima