Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize theme for Day Planner #237

Open
ceciliamay opened this issue Aug 30, 2024 · 3 comments
Open

Optimize theme for Day Planner #237

ceciliamay opened this issue Aug 30, 2024 · 3 comments
Assignees
Labels
🔌 plugin support Suggestion for an Obsidian plugin to support
Milestone

Comments

@ceciliamay
Copy link
Collaborator

ceciliamay commented Aug 30, 2024

Primary Theme Version

v2.9.0

What Community Plugin do you want to get Supported?

Day Planner

Please add the link to the Community Plugin

obsidian://show-plugin?id=obsidian-day-planner

Do you have any specifics to share?

optimize Primary for Day Planner plugin

  • style plugin for both sidebar and editor view
  • consider how it looks when the pane is narrow
  • style week planner
  • style plugin's dropdown menu: filter, settings
  • consider progress bar of day planner on status bar
@ceciliamay ceciliamay added the 🔌 plugin support Suggestion for an Obsidian plugin to support label Aug 30, 2024
@ceciliamay ceciliamay self-assigned this Aug 30, 2024
@ceciliamay ceciliamay moved this to Todo in ⭕ All Tasks Aug 30, 2024
@ceciliamay ceciliamay added this to the 2.11.0 milestone Sep 13, 2024
@ceciliamay
Copy link
Collaborator Author

ceciliamay commented Sep 20, 2024

reviewed styling that needs to be done this morning. some notes:

  • properly style the top nav header button's cast shadow (currently looks muddy) through --shadow-color or overriding box-shadow styling
  • add font-size variable to .content so that users can adjust how big their timebox font-size is + this should be connected to --checkbox-size in .rendered-markdown so that they grow-shrink together
  • style .workspace-leaf-content[data-type="weekly"]
  • make time indicator left column in the timeline flush to the timebox area (use same color)
  • top nav buttons are using grid instead of flex. set justify-content to space-around.
  • nav buttons need to be styled like nav header buttons by specifying the correct normal state, hover state, and pressed state styling for consistency
  • add a color variable to .ball and .needle to allow users to color the needle through style settings
  • style the date button similar to how a currently opened daily note is styled in the calendar (by liam cain) plugin
  • make time indicator text bold
  • change --time-block-border-color, --time-block-bg-color
  • remove border-color setting ofinput[type="checkbox"].task-list-item-checkbox (so that it takes in the theme's styling for checkboxes, which should properly allow styling for alt checkboxes within day planner)

@ceciliamay
Copy link
Collaborator Author

ceciliamay commented Sep 23, 2024

ok this is pretty much done but i just need to optimize it for dark mode.

  • optimize for dark mode

ceciliamay added a commit that referenced this issue Sep 24, 2024
@ceciliamay
Copy link
Collaborator Author

ceciliamay commented Sep 25, 2024

just need to find a way for the checkboxes not to get the border that's styled by day planner.

  • remove checkbox-border and ensure it inherits so that checkbox icons are usable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔌 plugin support Suggestion for an Obsidian plugin to support
Projects
Status: In Review
Development

No branches or pull requests

1 participant