Merge pull request #15156 from primefaces/issue-14949

Fixed #14949 - Dialog | Missing Aria Label on Maximize button
primefaces · Mar 26, 2024 · d5ec062 · d5ec062
2 parents a5677fd + f8ee175
commit d5ec062
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/src/app/components/api/primengconfig.ts b/src/app/components/api/primengconfig.ts
@@ -140,7 +140,8 @@ export class PrimeNGConfig {
             listLabel: 'Option List',
             selectColor: 'Select a color',
             removeLabel: 'Remove',
-            browseFiles: 'Browse Files'
+            browseFiles: 'Browse Files',
+            maximizeLabel: 'Maximize'
         }
     };
 

diff --git a/src/app/components/api/translation.ts b/src/app/components/api/translation.ts
@@ -131,4 +131,5 @@ export interface Aria {
     selectColor?: string;
     removeLabel?: string;
     browseFiles?: string;
+    maximizeLabel?: string;
 }
diff --git a/src/app/components/dialog/dialog.ts b/src/app/components/dialog/dialog.ts
@@ -25,7 +25,7 @@ import {
     ViewEncapsulation,
     ViewRef
 } from '@angular/core';
-import { Footer, Header, PrimeNGConfig, PrimeTemplate, SharedModule } from 'primeng/api';
+import { Footer, Header, PrimeNGConfig, PrimeTemplate, SharedModule, TranslationKeys } from 'primeng/api';
 import { DomHandler } from 'primeng/dom';
 import { FocusTrapModule } from 'primeng/focustrap';
 import { TimesIcon } from 'primeng/icons/times';
@@ -101,6 +101,7 @@ const hideAnimation = animation([animate('{{transition}}', style({ transform: '{
                                 (click)="maximize()"
                                 (keydown.enter)="maximize()"
                                 [attr.tabindex]="maximizable ? '0' : '-1'"
+                                [attr.aria-label]="maximizeLabel"
                                 pRipple
                                 pButton
                             >
@@ -540,6 +541,10 @@ export class Dialog implements AfterContentInit, OnInit, OnDestroy {
 
     private window: Window;
 
+    get maximizeLabel(): string {
+        return this.config.getTranslation(TranslationKeys.ARIA)['maximizeLabel'];
+    }
+
     constructor(@Inject(DOCUMENT) private document: Document, @Inject(PLATFORM_ID) private platformId: any, public el: ElementRef, public renderer: Renderer2, public zone: NgZone, private cd: ChangeDetectorRef, public config: PrimeNGConfig) {
         this.window = this.document.defaultView as Window;
     }