Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidebar wrong animation and close button display #10261

Closed
Hazzard17h opened this issue May 20, 2021 · 0 comments · Fixed by #10273
Closed

Sidebar wrong animation and close button display #10261

Hazzard17h opened this issue May 20, 2021 · 0 comments · Fixed by #10273
Assignees
@yigitfindikli
Labels
LTS-FIXED-11.4.8 Fixed in PrimeNG LTS 11.4.8 Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
12.0.0-Final

Comments

@Hazzard17h
Copy link 

[x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Plunkr Case (Bug Reports)
https://stackblitz.com/edit/primeng-sidebar-demo-vi4yki (use the last right-arrow button)

Current behavior (since PrimeNG 11.4.1 or 11.4.2)
If explicitly setting position="left" the sidebar seems to appear from right.
Also, if setting [showCloseIcon]="false" the header is still displayed, and results in much empty space at the top of the sidebar.

Expected behavior
Sidebar should appear from left and the header should not be displayed.

Please tell us about your environment:

  • Angular version: 11.2.14
  • PrimeNG version: 11.4.2
@yigitfindikli yigitfindikli added the Status: Pending Review Issue or pull request is being reviewed by Core Team label May 20, 2021
@Hazzard17h Hazzard17h mentioned this issue May 25, 2021
Merged
@yigitfindikli yigitfindikli added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Jun 4, 2021
@yigitfindikli yigitfindikli added this to the 12.0.0-Final milestone Jun 4, 2021
@yigitfindikli yigitfindikli self-assigned this Jun 4, 2021
yigitfindikli added a commit that referenced this issue Jun 4, 2021
@yigitfindikli
Merge pull request #10273 from Hazzard17h/10261-sidebar-wrong-animati…
bbbc6ed 
…on-and-close-button-display

Fixed #10261 - Sidebar wrong animation and close button display
yigitfindikli added a commit that referenced this issue Jun 4, 2021
@yigitfindikli
Refactor #10261
58a958c
@yigitfindikli yigitfindikli added LTS-FIXED-11.4.8 Fixed in PrimeNG LTS 11.4.8 and removed LTS-PORTABLE labels Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yigitfindikli yigitfindikli

Labels
LTS-FIXED-11.4.8 Fixed in PrimeNG LTS 11.4.8 Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
12.0.0-Final
Development

Successfully merging a pull request may close this issue.

Fixed #10261 - Sidebar wrong animation and close button display Hazzard17h/primeng
2 participants
@yigitfindikli @Hazzard17h