Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component: Dynamic Dialog resize change doesn't work #13158

Closed
wkubasik opened this issue Jun 7, 2023 · 0 comments · Fixed by #13198
Closed

Component: Dynamic Dialog resize change doesn't work #13158

wkubasik opened this issue Jun 7, 2023 · 0 comments · Fixed by #13198
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@wkubasik
Copy link

wkubasik commented Jun 7, 2023

Describe the bug

Resizable handle in the dynamic dialog doesn't work, when the dialog was opened with resizable: false and then the flag was updated in the dialog to true this.dialogConfig.resizable = true;.

Environment

No specific environment.

Reproducer

https://stackblitz.com/edit/primeng-resizable-dialog-issue-p4ycjr

Angular version

15.2.4

PrimeNG version

15.2.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.10.0

Browser(s)

No response

Steps to reproduce the behavior

  1. Open a dialog using DialogService and set the 'resizable' flag to false:
this.dialogService.open(ExampleDialogComponent, {
    header: 'Dialog header',
    resizable: false
});
  1. Change the flag to true in the dialog using DynamicDialogConfig:
this.dialogConfig.resizable = true;
  1. Resizable handle is present in the dialog (we can see it on hover and in the HTML) but it doesn't work and we cannot resize the dialog.
    image

Expected behavior

We should be able to open a dialog with resizable: false, then update the flag from the dialog to true and the resize handle should work as expected.

@wkubasik wkubasik added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jun 7, 2023
volvachev added a commit to volvachev/primeng that referenced this issue Jun 14, 2023
@cetincakiroglu cetincakiroglu added this to the 16.0.1 milestone Jun 16, 2023
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
2 participants