Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

p-tabPanel does not detect changes when "headerStyle", "headerStyleClass" binding is changed #13746

Closed
Feher-Zsofia opened this issue Sep 26, 2023 · 0 comments · Fixed by #13747
Closed

p-tabPanel does not detect changes when "headerStyle", "headerStyleClass" binding is changed #13746

Feher-Zsofia opened this issue Sep 26, 2023 · 0 comments · Fixed by #13747
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
16.4.0

Comments

@Feher-Zsofia
Copy link
Contributor

Feher-Zsofia commented Sep 26, 2023 •
edited
Loading

Describe the bug

[x] bug report
[ ] feature request
[ ] support request

Demo on Stackblitz
https://stackblitz.com/edit/primeng-tabview-style-bug

Current behavior
When I change the [headerStyleClass] binding of a p-tabPanel component, the change is only detected when I click on any other tab than the currently selected.

Expected behavior
When I change the [headerStyleClass] binding of a p-tabPanel component, I expect the component to change to state immediately.

Also seen here:
#9475 (comment)

Environment

OS: Windows 11

Angular version

14.1.3

PrimeNG version

14.0.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.16.0

Browser(s)

Chrome 117
@Feher-Zsofia Feher-Zsofia added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Sep 26, 2023
Feher-Zsofia added a commit to Feher-Zsofia/primeng that referenced this issue Sep 26, 2023
@Feher-Zsofia
Update tabview.ts
a73867b 
primefaces#13746
@Feher-Zsofia Feher-Zsofia mentioned this issue Sep 26, 2023
Merged
@cetincakiroglu cetincakiroglu added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add labels Sep 26, 2023
@cetincakiroglu cetincakiroglu added this to the 16.4.0 milestone Sep 26, 2023
cetincakiroglu added a commit that referenced this issue Sep 26, 2023
@cetincakiroglu
Merge pull request #13747 from Feher-Zsofia/patch-2
b7698dd 
Fix for #13746, tabview style changes are not immediately registered
anlampe pushed a commit to kleinod21/primeng that referenced this issue Jan 22, 2024
@Feher-Zsofia @anlampe
Update tabview.ts
d75faaa 
primefaces#13746
(cherry picked from commit a73867b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
16.4.0
Development

Successfully merging a pull request may close this issue.

Fix for #13746, tabview style changes are not immediately registered Feher-Zsofia/primeng
2 participants
@cetincakiroglu @Feher-Zsofia