Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pButton | Loading icon problem #13901

Closed
GiacomoDM opened this issue Oct 17, 2023 · 0 comments · Fixed by #13922
Closed

pButton | Loading icon problem #13901

GiacomoDM opened this issue Oct 17, 2023 · 0 comments · Fixed by #13922
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
16.6.0

Comments

@GiacomoDM
Copy link
Contributor

Describe the bug

For buttons with the directive pButton, when the loading property changes and the loading icon is removed, an empty element take its place. This element has a margin that gives the button an empty space next to the label where the loading icon was:
pbutton

image

Environment

Windows

Reproducer

https://stackblitz.com/edit/gmhqyu-xzl3yd?file=src%2Fapp%2Fdemo%2Fbutton-loading-demo.html

Angular version

16.X

PrimeNG version

16.5.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.16

Browser(s)

No response

Steps to reproduce the behavior

  1. Open the provided stackblitz
  2. The two buttons have the same spacing around the label
  3. click one of the two buttons
  4. wait for the loader to stop
  5. the button with the directive pButton now has additional spacing where the loading icon was. Furthermore, the remaining span has a css class named: .undefined'

Expected behavior

When the icon is removed, the span containing it should be removed as well.
@GiacomoDM GiacomoDM added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 17, 2023
eece added a commit to eece/primeng that referenced this issue Oct 18, 2023
@eece
fixed primefaces#13901 pButton | Loading icon problem
b03f77c
@eece eece mentioned this issue Oct 18, 2023
Merged
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Oct 25, 2023
@cetincakiroglu cetincakiroglu added this to the 16.6.0 milestone Oct 25, 2023
eece added a commit to eece/primeng that referenced this issue Oct 25, 2023
@eece
fixed primefaces#13901 pButton | Loading icon problem
1905c5f
cetincakiroglu added a commit that referenced this issue Oct 26, 2023
@cetincakiroglu
Merge pull request #13922 from eece/issue-13901
2a6c82e 
fixed #13901 pButton | Loading icon problem
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
16.6.0
Development

Successfully merging a pull request may close this issue.

fixed #13901 pButton | Loading icon problem eece/primeng
2 participants
@GiacomoDM @cetincakiroglu