Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component: Carousel | Circular is broken when OnPush is enabled in parent components and it's initializing #13974

Closed
EnricoMessall opened this issue Oct 29, 2023 · 0 comments · Fixed by #13975
Closed

Component: Carousel | Circular is broken when OnPush is enabled in parent components and it's initializing #13974

EnricoMessall opened this issue Oct 29, 2023 · 0 comments · Fixed by #13975
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
16.7.0

Comments

@EnricoMessall
Copy link
Contributor

Describe the bug

Carousel on init might show the second item and circular option is not working. That can happen when the other application is also with Change Detection OnPush:
https://www.youtube.com/watch?v=pHR11Hw_OSE

With the fix, this is working again:
https://www.youtube.com/watch?v=iWcxPO9uFgU

Environment

Reproducer

No response

Angular version

16.2.3

PrimeNG version

16.6.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20.5.1

Browser(s)

Chrome, Safari

Steps to reproduce the behavior

No response

Expected behavior

No response
@EnricoMessall EnricoMessall added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 29, 2023
EnricoMessall added a commit to Arematics/primeng that referenced this issue Oct 29, 2023
@EnricoMessall
Fixed primefaces#13974 - Fixed carousel circular not working on init …
0edc617 
…in some cases

 + Format fixing
@EnricoMessall EnricoMessall mentioned this issue Oct 29, 2023
Merged
@EnricoMessall EnricoMessall changed the title Component: Carousel | Circular is broken when Component: Carousel | Circular is broken when OnPush is enabled in parent components and it's initializing Oct 30, 2023
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 1, 2023
@cetincakiroglu cetincakiroglu added this to the 16.7.0 milestone Nov 1, 2023
cetincakiroglu added a commit that referenced this issue Nov 1, 2023
@cetincakiroglu
Merge pull request #13975 from Arematics/issue-13974
366d5de 
Fixed #13974 - Fixed carousel circular not working on init in some cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
16.7.0
Development

Successfully merging a pull request may close this issue.

Fixed #13974 - Fixed carousel circular not working on init in some cases Arematics/primeng
2 participants
@EnricoMessall @cetincakiroglu