Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multiselect: clicking directly on the svg icon closes the overlay #14335

Closed
angelo-v opened this issue Dec 12, 2023 · 1 comment · Fixed by #14353
Closed

multiselect: clicking directly on the svg icon closes the overlay #14335

angelo-v opened this issue Dec 12, 2023 · 1 comment · Fixed by #14353
Assignees
@mehmetcetin01140
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
17.1.0

Comments

@angelo-v
Copy link

angelo-v commented Dec 12, 2023 •
edited
Loading

Describe the bug

When clicking directly on the checkmark svg icon of a selected element, the overlay closes, but it should stay open.

The svg is hard to hit manually in with the default theme, but in our theme it is very likely to click and anyoing that the overlay then closes.

Environment

Angular web application

Reproducer

No response

Angular version

16

PrimeNG version

>14

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18

Browser(s)

Chrome

Steps to reproduce the behavior

To reproduce visit https://primeng.org/multiselect open one of the examples selects and check an element, then execute in the dev console:

document.querySelectorAll('.p-checkbox-icon')[0].dispatchEvent(new Event('click', {bubbles: true}))

Expected behavior

The overlay stays open
@angelo-v angelo-v added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 12, 2023
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 13, 2023
@cetincakiroglu cetincakiroglu added this to the 17.1.0 milestone Dec 13, 2023
mehmetcetin01140 added a commit that referenced this issue Dec 13, 2023
@mehmetcetin01140
Fixed #14335 - Multiselect | clicking directly on the svg icon closes…
d0ce08d 
… the overlay
@mehmetcetin01140 mehmetcetin01140 mentioned this issue Dec 13, 2023
Merged
cetincakiroglu added a commit that referenced this issue Dec 13, 2023
@cetincakiroglu
Merge pull request #14353 from primefaces/issue-14335
636a4a5 
Fixed #14335 - Multiselect | clicking directly on the svg icon closes…
@thecooper
Copy link

Is there any way I could get this added to version 16?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mehmetcetin01140 mehmetcetin01140

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
17.1.0
Development

Successfully merging a pull request may close this issue.

Fixed #14335 - Multiselect | clicking directly on the svg icon closes… primefaces/primeng
4 participants
@angelo-v @thecooper @cetincakiroglu @mehmetcetin01140