Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialog: Ensures every ARIA dialog and alertdialog node has an accessible name. #14950

Closed
WTW-Steve-Martin opened this issue Mar 5, 2024 · 0 comments · Fixed by #15075
Closed

Dialog: Ensures every ARIA dialog and alertdialog node has an accessible name. #14950

WTW-Steve-Martin opened this issue Mar 5, 2024 · 0 comments · Fixed by #15075
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
17.12.0

Comments

@WTW-Steve-Martin
Copy link

Describe the bug

The Axe Dev Tools for Accessibility is reporting the following issue:
image

Axe is highlighting that the dialog has a missing aria-label.

Please could we update this control so that the Axe scan passes?

Environment

Windows 10

Reproducer

No response

Angular version

17.2.3

PrimeNG version

17.9.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.18.0

Browser(s)

No response

Steps to reproduce the behavior

  1. Install the Axe Dev Tools for Accessibility plug-in.
  2. Visit the PrimeNG dialog page (https://primeng.org/dialog) on Chrome/Edge browser.
  3. Scan the page with Axe

Expected behavior

The Axe scan doesn't return this error.
@WTW-Steve-Martin WTW-Steve-Martin added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 5, 2024
@mehmetcetin01140 mehmetcetin01140 added Component: Accessibility Issue or pull request is related to WCAG or ARIA and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Mar 18, 2024
@TaneliTuomola TaneliTuomola mentioned this issue Mar 19, 2024
Merged
TaneliTuomola pushed a commit to TaneliTuomola/primeng that referenced this issue Mar 19, 2024
fix primefaces#14950 ConfirmDialog ariaLabelledBy
3d1b487
TaneliTuomola pushed a commit to TaneliTuomola/primeng that referenced this issue Mar 19, 2024
fix primefaces#14950 DynamicDialog ariaLabelledBy
f9b7a98
@cetincakiroglu cetincakiroglu added this to the 17.12.0 milestone Mar 20, 2024
@cetincakiroglu cetincakiroglu added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Mar 20, 2024
cetincakiroglu added a commit that referenced this issue Mar 20, 2024
@cetincakiroglu
Merge pull request #15075 from TaneliTuomola/issue-14950
74e40df 
fix #14950 Dialog ariaLabelledBy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
17.12.0
Development

Successfully merging a pull request may close this issue.

fix #14950 Dialog ariaLabelledBy TaneliTuomola/primeng
3 participants
@cetincakiroglu @mehmetcetin01140 @WTW-Steve-Martin