Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[*]: whole page & browser tab is hanging after 17.11 update #15057

Closed
imaksp opened this issue Mar 15, 2024 · 4 comments · Fixed by #15090
Closed

[*]: whole page & browser tab is hanging after 17.11 update #15057

imaksp opened this issue Mar 15, 2024 · 4 comments · Fixed by #15090
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@imaksp
Copy link

imaksp commented Mar 15, 2024

Describe the bug

whole page & browser tab is hanging after 17.11 update, currently don't have regeneration as could not debug due to some infinite loop introduced by 17.11 version

Environment

NA

Reproducer

No response

Angular version

17.3.0

PrimeNG version

17.11

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20.x

Browser(s)

No response

Steps to reproduce the behavior

will add if I find something.

Expected behavior

there should not be any infinite loop & browser tab should not hang, there should be some tests to catch this issues with every new minor version update, I think team should stop accepting PR(s) without test case.

@imaksp imaksp added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 15, 2024
@imaksp
Copy link
Author

imaksp commented Mar 16, 2024

Hi, I have found possible issue for this , in version 17.11 following panelMenu related PR was merged:
#15042
it has created infinite loop issue on one of our page, if I remove use of panelMenu component our app works with 17.11 version.

@cetincakiroglu cetincakiroglu added this to the 17.12.0 milestone Mar 19, 2024
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Mar 19, 2024
@cetincakiroglu cetincakiroglu self-assigned this Mar 19, 2024
@cetincakiroglu
Copy link
Contributor

Hi,

The issue is related with #15057

@cetincakiroglu
Copy link
Contributor

Hi,

I've updated the relevant lines, could you please check it after the v17.12.0 release

@imaksp
Copy link
Author

imaksp commented Mar 21, 2024

Hi @cetincakiroglu 17.12 release has fixed this issue, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants