Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileUpload: Never cancels the upload request when I click on the cancel button. #15664

Closed
kubedan opened this issue May 23, 2024 · 0 comments · Fixed by #15668 · 4 remaining pull requests
Closed

FileUpload: Never cancels the upload request when I click on the cancel button. #15664

kubedan opened this issue May 23, 2024 · 0 comments · Fixed by #15668 · 4 remaining pull requests
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working v18-port
Milestone
17.18.9

Comments

@kubedan
Copy link
Contributor

kubedan commented May 23, 2024 •
edited
Loading

Describe the bug

If I upload a (large) file and cancel it before it has been uploaded, the HTTP upload request is never canceled.

Environment

Doesnt matter.

Reproducer

https://stackblitz.com/edit/zjfynw

Angular version

17.3.7

PrimeNG version

17.17.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

v18.20.3

Browser(s)

No response

Steps to reproduce the behavior

https://stackblitz.com/edit/zjfynw

Add file for upload
01-add-file-for-upload

Click on upload button
02-click-upload-button

Click on remove file button
03-click-cancel-upload

It continues uploading
04-continue-uploading

And it finishes uploading.
05-finishes-uploading

Expected behavior

When I click on the remove file button, it unsubscribes from the HTTP request.
06-http-request-canceled
@kubedan kubedan added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label May 23, 2024
kubedan pushed a commit to kubedan/primeng that referenced this issue May 23, 2024
Fixed primefaces#15664 - Cancel upload file request
2bdc54b
kubedan pushed a commit to kubedan/primeng that referenced this issue May 28, 2024
Fixed primefaces#15664 - Cancel upload file request
0f6bf27
@kubedan kubedan mentioned this issue May 30, 2024
Merged
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Aug 15, 2024
@cetincakiroglu cetincakiroglu added this to the 17.18.9 milestone Aug 15, 2024
cetincakiroglu added a commit that referenced this issue Aug 15, 2024
@cetincakiroglu
Merge pull request #15668 from kubedan/master
38462d8 
Fixed #15664 - Cancel upload file request
This was referenced Sep 6, 2024
Open
Open
This was referenced Sep 14, 2024
Open
Open
@Rodolphe33 Rodolphe33 mentioned this issue Oct 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working v18-port
Projects
None yet
Milestone
17.18.9
3 participants
@kubedan @cetincakiroglu @mehmetcetin01140