You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We use dynamic dialogs fairly aggressively in our applications and after the most recent update and now we get Maximum call stack size exceeded errors when opening certain ones:
I've traced this back to dialogs that don't have any focusable element on them at load (see the attached stackblitz). This can be worked around by setting config.focusOnShow = false; But we have hundreds of dialogs and having a focusable element isn't always even known until runtime. Would be great if this could be fixed so it doesn't explode if no element is found.
mehmetcetin01140
added
Type: Bug
Issue contains a bug related to a specific component. Something about the component is not working
and removed
Status: Needs Triage
Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
labels
Jun 25, 2024
The same issue happens in a normal dialog (primeng 17.18.2) component (p-dialog), if focusOnShow parameter is not set to false.
RangeError: Maximum call stack size exceeded
at Module.DomHandler (primeng-dialog.mjs:1152:1)
at Dialog.focus (primeng-dialog.mjs:423:25)
at Dialog.focus (primeng-dialog.mjs:438:18)
at Dialog.focus (primeng-dialog.mjs:438:18)
at Dialog.focus (primeng-dialog.mjs:438:18)
at Dialog.focus (primeng-dialog.mjs:438:18)
at Dialog.focus (primeng-dialog.mjs:438:18)
at Dialog.focus (primeng-dialog.mjs:438:18)
at Dialog.focus (primeng-dialog.mjs:438:18)
at Dialog.focus (primeng-dialog.mjs:438:18)
Describe the bug
We use dynamic dialogs fairly aggressively in our applications and after the most recent update and now we get
Maximum call stack size exceeded
errors when opening certain ones:I've traced this back to dialogs that don't have any focusable element on them at load (see the attached stackblitz). This can be worked around by setting
config.focusOnShow = false;
But we have hundreds of dialogs and having a focusable element isn't always even known until runtime. Would be great if this could be fixed so it doesn't explode if no element is found.Seems related to #15263
Environment
n/a
Reproducer
https://stackblitz.com/edit/github-a35oyt?file=src%2Fapp%2Fapp.component.html
Angular version
17.3.11
PrimeNG version
17.18.1
Build / Runtime
Angular CLI App
Language
TypeScript
Node version (for AoT issues node --version)
n/a
Browser(s)
No response
Steps to reproduce the behavior
No response
Expected behavior
No response
The text was updated successfully, but these errors were encountered: