Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Password: When disabled allows to edit on focus tab #15905

Closed
Pablo200206 opened this issue Jun 25, 2024 · 2 comments
Closed

Password: When disabled allows to edit on focus tab #15905

Pablo200206 opened this issue Jun 25, 2024 · 2 comments
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
17.18.2

Comments

@Pablo200206
Copy link
Contributor

Describe the bug

When using keyboard navigation with a disabled p-password, the component gets focused and allows to edit the content of the input

Environment

PrimeNG 17, can be tried in the documentation page https://primeng.org/password

Reproducer

https://primeng.org/password

Angular version

17

PrimeNG version

17.18.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18

Browser(s)

Edge

Steps to reproduce the behavior

No response

Expected behavior

No response
@Pablo200206 Pablo200206 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jun 25, 2024
@Pablo200206 Pablo200206 mentioned this issue Jun 25, 2024
Merged
@Pablo200206
Copy link
Contributor Author

I just created a PR, it looks that disabled wasn´t binded to the inner input, also, there weren´t disabled styles for it

@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jun 27, 2024
@cetincakiroglu cetincakiroglu added this to the 17.18.2 milestone Jun 27, 2024
cetincakiroglu added a commit that referenced this issue Jun 27, 2024
@cetincakiroglu
Merge pull request #15906 from Pablo200206/master
d77e5d8 
fix(p-password) add disabled atribute to inside input #15905
@mehmetcetin01140
Copy link
Contributor

mehmetcetin01140 commented Jun 27, 2024 •
edited
Loading

Fixed in #15906

@Rodolphe33 Rodolphe33 mentioned this issue Jul 19, 2024
Open
@diaz-rigo diaz-rigo mentioned this issue Jul 21, 2024
Open
@Rodolphe33 Rodolphe33 mentioned this issue Jul 26, 2024
Open
@Rodolphe33 Rodolphe33 mentioned this issue Aug 2, 2024
Open
This was referenced Aug 9, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
17.18.2
Development

No branches or pull requests
3 participants
@cetincakiroglu @mehmetcetin01140 @Pablo200206