Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSP errors #15965

Closed
cetincakiroglu opened this issue Jul 5, 2024 · 0 comments · Fixed by #15966 · 4 remaining pull requests
Closed

CSP errors #15965

cetincakiroglu opened this issue Jul 5, 2024 · 0 comments · Fixed by #15966 · 4 remaining pull requests
Assignees
@cetincakiroglu
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working Type: Security Issue contains a security problem or enhancement related to a specific component v18-port
Milestone
17.18.4

Comments

@cetincakiroglu
Copy link
Contributor

There are several csp errors with the components below:

  • calendar
  • carousel
  • confirmdialog
  • dialog
  • orderlist
  • picklist
  • table
  • toast

This happens due to wrong order of actions when appending the style elements to the DOM.

How it's now:

1- a style element is created in TS
2- a style element is added to the DOM
3- nonce attribute is added to the DOM

How it should be:

1- a style element is created in TS
2- the nonce attribute is added to the style element
3- style element is added to the DOM
@cetincakiroglu cetincakiroglu added this to the 17.18.4 milestone Jul 5, 2024
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jul 5, 2024
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working Type: Security Issue contains a security problem or enhancement related to a specific component and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jul 5, 2024
@cetincakiroglu cetincakiroglu self-assigned this Jul 5, 2024
@cetincakiroglu cetincakiroglu mentioned this issue Jul 5, 2024
Merged
cetincakiroglu added a commit that referenced this issue Jul 5, 2024
@cetincakiroglu
Merge pull request #15966 from primefaces/issue-15965
e804cd6 
Fixes #15965 - Fix order of actions for CSP
@SoyDiego SoyDiego mentioned this issue Jul 10, 2024
Merged
@Rodolphe33 Rodolphe33 mentioned this issue Aug 2, 2024
Open
@Rodolphe33 Rodolphe33 mentioned this issue Aug 9, 2024
Open
@lakshamanr lakshamanr mentioned this issue Aug 9, 2024
Closed
This was referenced Aug 16, 2024
Open
Open
This was referenced Aug 30, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cetincakiroglu cetincakiroglu

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working Type: Security Issue contains a security problem or enhancement related to a specific component v18-port
Projects
None yet
Milestone
17.18.4
2 participants
@cetincakiroglu @mehmetcetin01140