Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidebar: onHide not triggered via programmatic close #16507

Closed
saramcicchi opened this issue Oct 8, 2024 · 1 comment · Fixed by #16542
Closed

Sidebar: onHide not triggered via programmatic close #16507

saramcicchi opened this issue Oct 8, 2024 · 1 comment · Fixed by #16542
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
17.18.12

Comments

@saramcicchi
Copy link

Describe the bug

If you change the variable tied to the sidebar's visible input to true, onShow is triggered. However if you change it to false, onHide is not triggered.

See #13933, #14254, and #14450 for related issues.

Environment

Standard angular app

Reproducer

https://stackblitz.com/edit/nbkkb5-cfek47?file=src%2Fapp%2Fsidebar-basic-demo.ts

Angular version

18.0.1

PrimeNG version

17.18.11

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.20.0

Browser(s)

Firefox, Chrome

Steps to reproduce the behavior

No response

Expected behavior

No response
@saramcicchi saramcicchi added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 8, 2024
@bgoorden
Copy link

I encountered the same issue. In addition to the onHide not being triggered. The "visibleChange" is also not triggered via a programmatic close.

volvachev added a commit to volvachev/primeng that referenced this issue Oct 14, 2024
@volvachev
fix(primeng/p-sidebar): onHide event not send after close manually
838b8d7 
Fixes primefaces#16507.
@volvachev volvachev mentioned this issue Oct 14, 2024
Merged
@mehmetcetin01140 mehmetcetin01140 added this to the 17.18.12 milestone Nov 12, 2024
@mehmetcetin01140 mehmetcetin01140 added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
17.18.12
Development

Successfully merging a pull request may close this issue.

fix(primeng/p-sidebar): onHide event not send after close manually volvachev/primeng
3 participants
@saramcicchi @bgoorden @mehmetcetin01140