Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: reactive forms setValue does not work while editor formControl is in dialog that is not visible #16825

Open
stefanbildl opened this issue Nov 22, 2024 · 0 comments · May be fixed by #16826
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Milestone

Comments

@stefanbildl
Copy link

stefanbildl commented Nov 22, 2024

Describe the bug

When i embed the editor component in a (currently not shown) dialog component and call setValue on the FormControl, the control's value does not update because the editor is not attached to the DOM.

this is because the "delayedCommand" command is never executed.

My proposition:
remove delayedCommand, and execute the command immediately.

Environment

Dialog with Editor component

Reproducer

No response

Angular version

18.0.0

PrimeNG version

17.18.12

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

22.9.0

Browser(s)

No response

Steps to reproduce the behavior

Place editor component in a dialog (as a reactive FormControl).

set dialog to non visible

call setValue on FormControl

-> nothing is updated

Expected behavior

Value should be updated

@stefanbildl stefanbildl added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 22, 2024
stefanbildl added a commit to stefanbildl/primeng that referenced this issue Nov 22, 2024
…hile editor formControl is in dialog that is not visible
@mertsincan mertsincan added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 26, 2024
@mertsincan mertsincan added this to the 17.18.13 milestone Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants