Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved issue 10963 in panel menu #11367

Merged
merged 3 commits into from
Jan 26, 2023

Conversation

NilavPatel
Copy link
Contributor

@NilavPatel NilavPatel commented Mar 31, 2022

Fixes #10963
Fixes #12173

@NilavPatel
Copy link
Contributor Author

Solution for defect
#10963

@rodolfocipagauta
Copy link

rodolfocipagauta commented Jun 22, 2022

Sigo esperando la solución para este defecto.
Por el momento reemplace ese componente por el SLIDEMENU, por si a alguien le sirve como solución temporal.
Gracias.

@ColinNor
Copy link

Hi @NilavPatel will this problem be fixed in the near future?

@NilavPatel
Copy link
Contributor Author

Not sure, I have created pull request with solution, but no one has review and merge it.

@yigitfindikli yigitfindikli added this to the 13.4.2 milestone Jun 27, 2022
@yigitfindikli yigitfindikli self-requested a review June 27, 2022 13:43
@yigitfindikli yigitfindikli added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Jun 27, 2022
@yigitfindikli yigitfindikli modified the milestones: 14.0.0, 14.Future Jul 18, 2022
@Zagano-AOR
Copy link

Do you have any news on this one?... for us, this issue will define a go/no go with the latest version or keep PrimeNG version 9... the bad thing is that we bought the theme designer to do the migration, and now we are very disappointed since we have lots of panel menus inside sidebars :( !!

@NilavPatel
Copy link
Contributor Author

@yigitfindikli would you please take a look at this merge request? Lots of peoples are facing this issue now.

@ColinNor
Copy link

ColinNor commented Aug 4, 2022

I sent a mail to support and was told that this issue will be fixed in the next release

@Zagano-AOR
Copy link

Really, excellent news... I just can't wait

@AlexAvilaSantos
Copy link

<p-sidebar [(visible)]="visibleSidebar"  >
    <p-panelMenu *ngIf="visibleSidebar" [model]="modulos" autoDisplay="true"></p-panelMenu>
</p-sidebar>[](url)

lil trick, use same boolean for visible with ngif in panelMenu, have visual bug but works

@cetincakiroglu cetincakiroglu merged commit c8fcb14 into primefaces:master Jan 26, 2023
@cetincakiroglu
Copy link
Contributor

Hi @NilavPatel,

Thanks a lot for your first-time contribution!
Don't forget to run npm run build:check command before pushing changes.

@cetincakiroglu cetincakiroglu removed the Status: Pending Review Issue or pull request is being reviewed by Core Team label Jan 26, 2023
@cetincakiroglu cetincakiroglu modified the milestones: 15.Future, 15.1.2 Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants