Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(primeng/p-carousel): carousel wrong pagination, if data is loaded dynamically #12049

Merged
merged 1 commit into from
Nov 22, 2022
Merged

fix(primeng/p-carousel): carousel wrong pagination, if data is loaded dynamically #12049

merged 1 commit into from
Nov 22, 2022
+1 −1

Conversation

volvachev
Copy link
Contributor

@volvachev volvachev commented Oct 16, 2022 •
edited
Loading

###Defect Fixes
fix #12043

@github-actions
Copy link

👋 Hi,
Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@github-actions github-actions bot added the Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. label Oct 16, 2022
@github-actions
Copy link

👋 Hi,
Thanks a lot for your contribution! But, PR does not seem to be linked to any issues. Please manually link to an issue or mention it in the description using #<issue_id>.

@cetincakiroglu cetincakiroglu added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Oct 18, 2022
@cetincakiroglu
Copy link
Contributor

Hi @volvachev,

There are lots of conflicts in your PR, could you please resolve them so I can merge the PR safely?

@cetincakiroglu cetincakiroglu removed the Status: Pending Review Issue or pull request is being reviewed by Core Team label Nov 15, 2022
@volvachev volvachev force-pushed the fix-carousel-logic-for-dynamic-values branch from 7088737 to 3e56ae2 Compare November 15, 2022 16:23
@volvachev
Copy link
Contributor Author

Hi @volvachev,

There are lots of conflicts in your PR, could you please resolve them so I can merge the PR safely?

Hi, i did it

@cetincakiroglu cetincakiroglu removed the Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. label Nov 22, 2022
@cetincakiroglu cetincakiroglu merged commit 57656f7 into primefaces:master Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Carousel wrong pagination if numScroll is set to 1 and data is loaded dynamically
2 participants
@volvachev @cetincakiroglu