Fix Issue 12493: Last slot of reorderable table breaks when page is scrolled #12853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
cetincakiroglu
added
Type: Bug
cetincakiroglu
approved these changes
Apr 25, 2023
cetincakiroglu
removed
the
Type: Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defect Fixes
Fixes #12493
Fixes #10003
Solution
Apparently the
rowYvalue was being offset by the window scroll twice:Which wouldn't allow the condition
pageY < rowMidYto betrue, so no bottom slots would work after a certain scroll amount.Both sections trace back to the same commit.
However, no other occurrence of
getOffseton the project required an extragetWindowScrollTop:There were no tests related to this to be updated, but manual tests on the
showcaseindicate the fix works.