Added customSizes to fileupload component

[SoyDiego]

closes #13398

Added customSizes to personalize the units to display. This allow the internationalization
By default is: ['B', 'KB', 'MB', 'GB', 'TB', 'PB', 'EB', 'ZB', 'YB'].

Example with french units: ['o', 'ko', 'Mo', 'Go', 'To', 'Po', 'Eo', 'Zo', 'Yo']

Added documentation

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
primeng-ssr-test	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 29, 2023 3:30pm

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
primeng	⬜️ Ignored (Inspect)	Visit Preview		Aug 29, 2023 3:30pm

[ajjp]

Thanks for the solution.

Just one remark: line 836 is missing the translation. I suggest this modification:

    const sizes = this.customSizes || ['B', 'KB', 'MB', 'GB', 'TB', 'PB', 'EB', 'ZB', 'YB'];
    if (bytes === 0) {
        return `0 ${sizes[0]}`;
    }

    const k = 1000;
    const dm = 3;

[SoyDiego]

Thanks for the solution.

Just one remark: line 836 is missing the translation. I suggest this modification:

    const sizes = this.customSizes || ['B', 'KB', 'MB', 'GB', 'TB', 'PB', 'EB', 'ZB', 'YB'];
    if (bytes === 0) {
        return `0 ${sizes[0]}`;
    }

    const k = 1000;
    const dm = 3;

Thanks @ajjp,I forgot that part. Now I added :)

[mertsincan]

Hi @SoyDiego,

I think you can add a locale option for it. https://github.com/primefaces/primelocale

en = {
...
   fileSizeTypes: ['B', 'KB', 'MB', 'GB', 'TB', 'PB', 'EB', 'ZB', 'YB']
}

fr = {
...
   fileSizeTypes: ['o', 'ko', 'Mo', 'Go', 'To', 'Po', 'Eo', 'Zo', 'Yo']
}

[SoyDiego]

Hi @SoyDiego,

I think you can add a locale option for it. https://github.com/primefaces/primelocale

en = {
...
   fileSizeTypes: ['B', 'KB', 'MB', 'GB', 'TB', 'PB', 'EB', 'ZB', 'YB']
}

fr = {
...
   fileSizeTypes: ['o', 'ko', 'Mo', 'Go', 'To', 'Po', 'Eo', 'Zo', 'Yo']
}

Hi, that is new, right?

Hi @SoyDiego,

I think you can add a locale option for it. https://github.com/primefaces/primelocale

en = {
...
   fileSizeTypes: ['B', 'KB', 'MB', 'GB', 'TB', 'PB', 'EB', 'ZB', 'YB']
}

fr = {
...
   fileSizeTypes: ['o', 'ko', 'Mo', 'Go', 'To', 'Po', 'Eo', 'Zo', 'Yo']
}

Hi, I don't think so because currently you assign that values and you cannot change.
With this PR you will.

But maybe this is another thing that you should talk as a team because in PrimeVue and PrimeReact you should implement too. It's a new feature and I don't know if you want this feature.

[mertsincan]

Hi @SoyDiego,

Yes, it should be a new locale option. Please see our default locale options;
https://github.com/primefaces/primeng/blob/master/src/app/components/api/primengconfig.ts#L19

Users can automatically change the value of 'fileSizeTypes' by selecting any locale. I don't think there is a need for a separate FileUpload attribute for this.

Note: The change of 'dayNames' in Calendar according to locale can give you a clue. We would be grateful if you could send a PR to PrimeNg and others. I'll merge them ;)

Thanks a lot for your contribution! We really appreciate your PRs 🚀
Best Regards,

[SoyDiego]

Ok, great, so we can close this PR if it's not necessary @mertsincan

[mertsincan]

A new PR would be better ;) Thank you so much for your effort!

[SoyDiego]

A new PR would be better ;) Thank you so much for your effort!

Ok great now I understood. I wrote you in private in Discord just in case.