Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 13862: MultiSelect: Label does not properly update when properties change #13863

Closed
wants to merge 2 commits into from

Conversation

doener006
Copy link

Fixes #13862

@vercel
Copy link

vercel bot commented Oct 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
primeng-ssr-test ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2023 6:10am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview Oct 12, 2023 6:10am

@trytuna
Copy link

trytuna commented Oct 17, 2023

This is brilliant! Would be nice if this gets merged

@cetincakiroglu
Copy link
Contributor

Hi,

We've recently reworked the multiselect component and because of this label logic has changed also. Your PR seems correct and I want to merge but there isn't updateLabel method anymore. We'll implement these changes as core team by referencing your PR.

Thanks a lot for the effort and support!

Closing the PR

cetincakiroglu added a commit that referenced this pull request Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MultiSelect: Label does not properly update when properties change
4 participants