Fixed #15804 - Advance Filtering is broken (revert PR #15594 changes) #15808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
rosenthalj
changed the title
|
Over the weekend I have been thinking about the how to FULLY fix this problem (issue #15811, issue #15778, issue #15557). I believe that the best/proper solution is when the filter overlay/dialog is hidden (via the hide method or any other means) the overlay/dialog is completely destroyed. When the the filter/dialog is displayed, it is always created and filled with the current filter setting. This is obviously not a trivial solution or this bug would have fixed (or initially implemented) years ago with this approach. I believe that this PR #15808 (reverting changes made by PR #15594), is the most prudent near-term fix. |
This was referenced Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts the changes made in PR #15594
This PR also fixes issue #15778
This PR fixes the functionality of the PrimeNG's Table Advance Filters which was "Critically" broken when trying to fix issue #15557. Note: PR #15594 actually only partially fixed issue #15557.
This PR also breaks issue #15557. Since the problem identified in issue #15557 has been in PrimeNG for multiple years without being fixed, I believe it is better to fix the Advance Filter immediately and in the future develop a more holistic/complete fix for issue #15557 that doesn't "critically" break Advance Table Filters