Updated styles to resolve issue #15534, New severity not reflected in… #15908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…flected in styles
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
SoyDiego
approved these changes
Jun 25, 2024
|
Hi @chris-stillwell, This issue is caused by a type mismatch in the message component. We've checked the styles in primeng-sass-theme repo where all component styles were generated and found that the styles are correct and classes should be -warn & -error. However, the message component should have 'warn' and 'error' severities instead of warning and danger as of 17.18.0 release. We've updated the type mismatch which will fix the issue in #15928 Thanks a lot for the effort and support you've put in with this PR, we appreciate it. However, since it isn't related to styles, I'm closing this PR. Don't hesitate to send PRs to make PrimeNG better! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… styles
Defect Fixes
This will resolve issue #15534 where the new
dangerseverity does not have any style.