Skip to content

Commit

Permalink
Fic #4704: typescript order for closeOnEscape (#4755)
Browse files Browse the repository at this point in the history
  • Loading branch information
melloware authored Aug 9, 2023
1 parent 29791b8 commit 89cebb1
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 10 deletions.
10 changes: 5 additions & 5 deletions components/lib/image/image.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,11 @@ export interface ImageProps extends Omit<React.DetailedHTMLProps<React.HTMLAttri
* @readonly
*/
children?: React.ReactNode | undefined;
/**
* Specifies if pressing escape key should hide the preview.
* @defaultValue true
*/
closeOnEscape?: boolean | undefined;
/**
* The crossorigin content attribute on media elements is a CORS settings attribute.
*/
Expand Down Expand Up @@ -247,11 +252,6 @@ export interface ImageProps extends Omit<React.DetailedHTMLProps<React.HTMLAttri
* @defaultValue false
*/
unstyled?: boolean;
/**
* Specifies if pressing escape key should hide the preview.
* @defaultValue true
*/
closeOnEscape?: boolean | undefined;
}

/**
Expand Down
10 changes: 5 additions & 5 deletions components/lib/overlaypanel/overlaypanel.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,11 @@ export interface OverlayPanelProps extends Omit<React.DetailedHTMLProps<React.HT
* Icon to display as close icon.
*/
closeIcon?: IconType<OverlayPanelProps> | undefined;
/**
* Specifies if pressing escape key should hide the preview.
* @defaultValue true
*/
closeOnEscape?: boolean | undefined;
/**
* DOM element instance where the overlay panel should be mounted. Valid values are any DOM Element and 'self'. The self value is used to render a component where it is located.
* @defaultValue document.body
Expand Down Expand Up @@ -125,11 +130,6 @@ export interface OverlayPanelProps extends Omit<React.DetailedHTMLProps<React.HT
* @defaultValue false
*/
unstyled?: boolean;
/**
* Specifies if pressing escape key should hide the preview.
* @defaultValue true
*/
closeOnEscape?: boolean | undefined;
}

/**
Expand Down

0 comments on commit 89cebb1

Please sign in to comment.