Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Growl does not clear timeout on unmount #272

Closed
RushPVA opened this issue Jan 5, 2018 · 4 comments
Closed

Growl does not clear timeout on unmount #272

RushPVA opened this issue Jan 5, 2018 · 4 comments
Assignees
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone

Comments

@RushPVA
Copy link

RushPVA commented Jan 5, 2018

Warning: setState(...): Can only update a mounted or mounting component. This usually means you called setState() on an unmounted component. This is a no-op. Please check the code for the Growl component.

stack_frame_overlay_proxy_console
index.js:2177
printWarning
warning.js:33
warning
warning.js:57
getInternalInstanceReadyForUpdate
ReactUpdateQueue.js:46
enqueueSetState
ReactUpdateQueue.js:207
./node_modules/react/lib/ReactBaseClasses.js/ReactComponent.prototype.setState
ReactBaseClasses.js:62
onClose
Growl.js:94
onClose
GrowlMessage.js:62
componentDidMount/this.timeout<
GrowlMessage.js:50

@cagataycivici
Copy link
Member

Please provide a plunkr to help us replicate;

https://plnkr.co/edit/C6qjkdLtbmy92Hogdnjb?p=preview

@RushPVA
Copy link
Author

RushPVA commented Feb 13, 2018

i can't add growl to this plunkr page

common.js:85 Uncaught (in promise) Error: Fetch error: 404
Instantiating https://unpkg.com/CSSTransition
Loading https://unpkg.com/react-transition-group@2.2.1

@RushPVA
Copy link
Author

RushPVA commented Feb 13, 2018

Anyway maybe i can explain in details:

  1. i use react router
  2. one page contains growl, another doesn't contain
  3. if i open first page and trigger growl message, then click link to another page, before message is disappeared i ll see above message in console

@cagataycivici
Copy link
Member

Got it, I tried on showcase and see the message.

@cagataycivici cagataycivici self-assigned this Feb 13, 2018
@cagataycivici cagataycivici added the Type: Bug Issue contains a defect related to a specific component. label Feb 13, 2018
@cagataycivici cagataycivici added this to the 1.4.1 milestone Feb 13, 2018
@cagataycivici cagataycivici changed the title Growl throws warning if component is unmounted before message is closed Growl does not clear timeout on unmount Feb 13, 2018
cagataycivici pushed a commit that referenced this issue Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

No branches or pull requests

2 participants