Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SplitButton: className in menu api does not work #3757

Closed
DenisRoss opened this issue Dec 8, 2022 · 1 comment · Fixed by #3759
Closed

SplitButton: className in menu api does not work #3757

DenisRoss opened this issue Dec 8, 2022 · 1 comment · Fixed by #3759
Assignees
@melloware
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
9.0.0-beta.1

Comments

@DenisRoss
Copy link

Describe the bug

className in menu api does not work in splitbutton component

  const items = [
    {
      label: "Test",
      className: "test" // <=== THIS IS BROKEN
    }
  ]

  <SplitButton label="Save" icon="pi pi-plus" model={items} />

Reproducer

https://codesandbox.io/s/red-wood-67i80h?file=/src/demo/SplitButtonDemo.js:310-321

PrimeReact version

8.7.3

React version

17.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@DenisRoss DenisRoss added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 8, 2022
@DenisRoss DenisRoss changed the title Component: Title className in menu api does not work in splitbutton component Dec 8, 2022
@melloware melloware changed the title className in menu api does not work in splitbutton component SplitButton: className in menu api does not work Dec 8, 2022
melloware added a commit to melloware/primereact that referenced this issue Dec 8, 2022
@melloware
Fix primefaces#3757: Splitbutton repsect menu API className
c52d560
@melloware melloware self-assigned this Dec 8, 2022
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 8, 2022
@melloware melloware added this to the 8.7.4 milestone Dec 8, 2022
@melloware
Copy link
Member

Thanks for the report and reproducer!

@melloware melloware mentioned this issue Dec 8, 2022
Merged
melloware added a commit that referenced this issue Dec 8, 2022
@melloware
Fix #3757: Splitbutton repsect menu API className (#3759)
1109712
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
9.0.0-beta.1
Development

Successfully merging a pull request may close this issue.

Fix #3757: Splitbutton repsect menu API className melloware/primereact
2 participants
@melloware @DenisRoss