Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataTable: Error when 'virtualScrollerOptions.showLoader' + 'dataKey' are enabled #3803

Closed
ghost opened this issue Dec 20, 2022 · 0 comments · Fixed by #3805
Closed

DataTable: Error when 'virtualScrollerOptions.showLoader' + 'dataKey' are enabled #3803

ghost opened this issue Dec 20, 2022 · 0 comments · Fixed by #3805
Assignees
@melloware
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
9.0.0-beta.1

Comments

@ghost
Copy link

ghost commented Dec 20, 2022

Describe the bug

when grid has virtualScrollerOptions.showLoader set to true and a dataKey set, it throws error on scroll:
Cannot read properties of undefined (reading 'id')

Reproducer

https://codesandbox.io/s/react-typescript-forked-vib9wr?file=/src/App.tsx

PrimeReact version

8.7.3

React version

18.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

Edge

Steps to reproduce the behavior

  1. Open sandbox
  2. Scroll data table
  3. Error

Expected behavior

it shouldnt break
@ghost ghost added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 20, 2022
@ghost ghost changed the title DataTable: Error when 'virtualScrollerOptions.showLoader' + "dataKey' are enabeld DataTable: Error when 'virtualScrollerOptions.showLoader' + "dataKey' are enabled Dec 20, 2022
@ghost ghost changed the title DataTable: Error when 'virtualScrollerOptions.showLoader' + "dataKey' are enabled DataTable: Error when 'virtualScrollerOptions.showLoader' + 'dataKey' are enabled Dec 20, 2022
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 20, 2022
@melloware melloware self-assigned this Dec 20, 2022
@melloware melloware added this to the 8.7.4 milestone Dec 20, 2022
melloware added a commit to melloware/primereact that referenced this issue Dec 20, 2022
@melloware
Fix primefaces#3803: Datatable error with datakey and virtualscroller
7c5443a
@melloware melloware mentioned this issue Dec 20, 2022
Merged
melloware added a commit that referenced this issue Dec 20, 2022
@melloware
Fix #3803: Datatable error with datakey and virtualscroller (#3805)
4a69929
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
9.0.0-beta.1
Development

Successfully merging a pull request may close this issue.

Fix #3803: Datatable error with datakey and virtualscroller melloware/primereact
1 participant
@melloware