Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidebar: dismissible not working immediately while sidebar is visible #3811

Closed
inad9300 opened this issue Dec 23, 2022 · 0 comments · Fixed by #3813
Closed

Sidebar: dismissible not working immediately while sidebar is visible #3811

inad9300 opened this issue Dec 23, 2022 · 0 comments · Fixed by #3813
Assignees
@melloware
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
9.0.0-beta.1

Comments

@inad9300
Copy link
Contributor

inad9300 commented Dec 23, 2022 •
edited
Loading

Describe the bug

Toggling dismissibility doesn't actually immediately toggle it. It is only after closing and reopening the sidebar that the dismissible flag is taken into account.

Possibly related to #2562 and #1065.

Reproducer

https://codesandbox.io/s/primereact-test-forked-ll7b2p?file=/src/index.js

PrimeReact version

8.7.3

React version

17.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

No response

Steps to reproduce the behavior

  1. Verify sidebar is dismissable.
  2. Open sidebar again.
  3. Set dismissable to false.
  4. Verify that sidebar still is dismissable, even though it shouldn't be.

Expected behavior

No response
@inad9300 inad9300 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 23, 2022
@melloware melloware self-assigned this Dec 23, 2022
@melloware melloware added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 23, 2022
@melloware melloware added this to the 8.7.4 milestone Dec 23, 2022
melloware added a commit to melloware/primereact that referenced this issue Dec 23, 2022
@melloware
Fix primefaces#3811: Sidebar toggle dissmissable state
415d158
@melloware melloware mentioned this issue Dec 23, 2022
Merged
melloware added a commit that referenced this issue Dec 23, 2022
@melloware
Fix #3811: Sidebar toggle dissmissable state (#3813)
8a8a8c0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
9.0.0-beta.1
Development

Successfully merging a pull request may close this issue.

Fix #3811: Sidebar toggle dissmissable state melloware/primereact
2 participants
@inad9300 @melloware